Skip to content

Conversation

@AaronDDM
Copy link
Collaborator

What did you do?

  • Updated example names in build.gradle.kts and Makefile for clarity.
  • Added new Java Events example to the list of available examples.
  • Enhanced logging in NylasClient to print the URL of GET requests.
  • Fixed ListEventQueryParams to use a more specific type for orderBy parameter and correct JSON name.

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

…rameter and correct JSON name.

- Updated example names in build.gradle.kts and Makefile for clarity.
- Added new Java Events example to the list of available examples.
- Enhanced logging in NylasClient to print the URL of GET requests.
- Fixed ListEventQueryParams to use a more specific type for orderBy parameter and correct JSON name.
@AaronDDM AaronDDM force-pushed the CUST-4375-v-3-java-sdk-does-not-support-order-by-like-the-api-does branch from 5a80cf9 to 5f69941 Compare May 20, 2025 13:48
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.57%. Comparing base (9d72614) to head (fcf3039).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #276   +/-   ##
=========================================
  Coverage     80.57%   80.57%           
  Complexity      333      333           
=========================================
  Files            36       36           
  Lines          1014     1014           
  Branches         88       88           
=========================================
  Hits            817      817           
  Misses          138      138           
  Partials         59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@playerzero-ai
Copy link

playerzero-ai bot commented May 20, 2025

Pull Request Summary

  • New Java Class (EventsExample):

    • Demonstrates interaction with the Nylas API to fetch and list calendar events.
    • Includes methods for configuration loading, Nylas client initialization, and event retrieval.
    • Supports fetching events within a specified time range and options to expand recurring events and show cancelled events.
    • Provides error handling for API and configuration issues.
  • Build Script Update (examples/build.gradle.kts):

    • Enhances the listExamples task to clearly list Java and Kotlin examples for Notetaker and Events, improving user navigation and experience.
  • Type Safety Improvement (ListEventQueryParams.kt):

    • Changes the orderBy parameter from a string to a new type EventQueryOrderBy, enhancing type safety and future-proofing for complex ordering.
  • New Enum Definition (EventQueryOrderBy.kt):

    • Introduces EventQueryOrderBy enum with a START option for sorting events by start time.
    • Improves event organization and retrieval capabilities by allowing sorting based on start times.

View more in PlayerZero
updated: May 20 @ 02:26 PM UTC

@AaronDDM AaronDDM requested a review from pooja169usp May 27, 2025 13:04
@AaronDDM AaronDDM merged commit f2bacd3 into main May 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants