-
Notifications
You must be signed in to change notification settings - Fork 18
Added logo_url and show_nylas_branding options and ability to turn off Nylas branding
#283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ajay-k can we update another test to show how it is being used for the actual API call? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #283 +/- ##
=========================================
Coverage 80.57% 80.57%
Complexity 333 333
=========================================
Files 36 36
Lines 1014 1014
Branches 88 88
=========================================
Hits 817 817
Misses 138 138
Partials 59 59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Aaron de Mello <314152+AaronDDM@users.noreply.github.com>
Co-authored-by: Aaron de Mello <314152+AaronDDM@users.noreply.github.com>
logo_url and show_nylas_branding options and ability to turn off Nylas branding
Yeah, looking into this |
Added support for two missing fields (logo_url & showNylasBranding ) in the EmailTemplate class that were documented in the Scheduler API Reference but not implemented in the Java/Kotlin SDK.
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.