Skip to content

Conversation

@ajay-k
Copy link
Contributor

@ajay-k ajay-k commented Jun 13, 2025

Added support for two missing fields (logo_url & showNylasBranding ) in the EmailTemplate class that were documented in the Scheduler API Reference but not implemented in the Java/Kotlin SDK.

  • Added proper JSON serialization with "Json" annotations ("logo", "show_nylas_branding")
  • Maintained backward compatibility - all new fields are optional
  • Included in Changelog

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@AaronDDM
Copy link
Collaborator

@ajay-k can we update another test to show how it is being used for the actual API call?

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.57%. Comparing base (d47b137) to head (a6ca51b).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #283   +/-   ##
=========================================
  Coverage     80.57%   80.57%           
  Complexity      333      333           
=========================================
  Files            36       36           
  Lines          1014     1014           
  Branches         88       88           
=========================================
  Hits            817      817           
  Misses          138      138           
  Partials         59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Aaron de Mello <314152+AaronDDM@users.noreply.github.com>
Co-authored-by: Aaron de Mello <314152+AaronDDM@users.noreply.github.com>
@AaronDDM AaronDDM changed the title Added logo_url option and ability to turn off Nylas branding Added logo_url and show_nylas_branding options and ability to turn off Nylas branding Jun 13, 2025
@ajay-k
Copy link
Contributor Author

ajay-k commented Jun 13, 2025

@ajay-k can we update another test to show how it is being used for the actual API call?

Yeah, looking into this

@ajay-k ajay-k merged commit ce3598c into main Jun 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants