Skip to content

Conversation

@AaronDDM
Copy link
Collaborator

@AaronDDM AaronDDM commented Aug 11, 2025

What did you do?

Added

  • CreateEventAutoConferencingProvider enum for autocreate conferencing providers in event creation
  • CreateEventManualConferencingProvider enum for manual conferencing providers in event creation
  • UpdateEventAutoConferencingProvider enum for autocreate conferencing providers in event updates
  • UpdateEventManualConferencingProvider enum for manual conferencing providers in event updates

Changed

  • Enhanced CreateEventRequest.Conferencing to use dedicated provider enums while maintaining backward compatibility
  • Enhanced UpdateEventRequest.Conferencing to use dedicated provider enums while maintaining backward compatibility

Deprecated

  • CreateEventRequest.Conferencing.Autocreate.fromConferencingProvider() - Use CreateEventAutoConferencingProvider instead
  • CreateEventRequest.Conferencing.Details.fromConferencingProvider() - Use CreateEventManualConferencingProvider instead
  • UpdateEventRequest.Conferencing.Autocreate.fromConferencingProvider() - Use UpdateEventAutoConferencingProvider instead
  • UpdateEventRequest.Conferencing.Details.fromConferencingProvider() - Use UpdateEventManualConferencingProvider instead

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.75%. Comparing base (603dc64) to head (d8543e8).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #292      +/-   ##
============================================
+ Coverage     81.26%   81.75%   +0.49%     
- Complexity      339      344       +5     
============================================
  Files            36       36              
  Lines          1014     1014              
  Branches         88       88              
============================================
+ Hits            824      829       +5     
  Misses          132      132              
+ Partials         58       53       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@playerzero-ai
Copy link

playerzero-ai bot commented Aug 11, 2025

Pull Request Summary

  • New Enums for Conferencing Providers: Introduced new enums for both manual and auto-conferencing providers to support specific platforms like Google Meet, Zoom, and Microsoft Teams for event creation and updates.

  • Backward Compatibility and Transition: Deprecated old methods and provided conversion mechanisms to transition from the old ConferencingProvider enum to the new enums, ensuring backward compatibility.

  • Serialization and Deserialization: Added JSON annotations to the new enums for proper serialization/deserialization, facilitating API interactions.

  • Testing Enhancements: Implemented comprehensive tests to verify the correct handling of new enums, ensuring proper serialization, deserialization, and backward compatibility.

  • Codebase Alignment: Updated CreateEventRequest and UpdateEventRequest classes to use new enums, aligning the codebase with updated conferencing provider structures.

  • Streamlining Providers: Reordered and simplified the ConferencingProvider enum, reflecting changes in integration priorities or user preferences.

Functional Tests

  • Verify that the ConferenceProvider correctly lists all supported conference types, including any deprecated ones, in the user interface.
  • Ensure that users can select and interact with all supported conference types without encountering errors.
  • Check that deprecated conference types are clearly marked as such in the UI and that users are informed appropriately when selecting them.

Files Changed

File Name Summary
src/main/kotlin/com/nylas/models/CreateEventManualConferencingProvider.kt Added enum for manual conferencing providers with Google Meet, Zoom, Microsoft Teams, Teams for Business, Skype for Business, and Skype for Consumer options.
src/main/kotlin/com/nylas/models/CreateEventRequest.kt Replaced ConferencingProvider with new enums for auto/manual providers; added companion objects for conversion; deprecated old conversion methods.
src/main/kotlin/com/nylas/models/CreateEventAutoConferencingProvider.kt Added enum for auto conferencing providers: Google Meet, Zoom, Microsoft Teams with JSON annotations.
src/main/kotlin/com/nylas/models/UpdateEventAutoConferencingProvider.kt Added enum for auto conferencing providers used in event updates: Google Meet, Zoom, Microsoft Teams.
src/test/kotlin/com/nylas/resources/EventsTests.kt Added tests for serialization/deserialization of new auto/manual provider enums, event requests, and backward compatibility with deprecated methods.
src/main/kotlin/com/nylas/models/UpdateEventRequest.kt Updated Autocreate and Details to use new update enums; deprecated old conversion methods; added companion objects for conversions.
src/main/kotlin/com/nylas/models/ConferencingProvider.kt Reordered enum values, added GOTOMEETING, removed SKYPE_FOR_CONSUMER to streamline supported providers.
src/main/kotlin/com/nylas/models/UpdateEventManualConferencingProvider.kt Added enum for manual conferencing providers in event updates with Google Meet, Zoom, Microsoft Teams, Teams for Business, Skype for Business, and Skype for Consumer.

View more in PlayerZero
updated: Aug 12 @ 02:30 PM UTC

@AaronDDM AaronDDM changed the title fix: ConferenceProvider did not include all the supported (and deprec… feat: add dedicated conferencing provider enums for create and update operations Aug 12, 2025
@AaronDDM AaronDDM requested review from quzhi1 and samuelpx August 12, 2025 14:22
@AaronDDM AaronDDM merged commit d63a3c9 into main Aug 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants