-
Notifications
You must be signed in to change notification settings - Fork 18
feat: add dedicated conferencing provider enums for create and update operations #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #292 +/- ##
============================================
+ Coverage 81.26% 81.75% +0.49%
- Complexity 339 344 +5
============================================
Files 36 36
Lines 1014 1014
Branches 88 88
============================================
+ Hits 824 829 +5
Misses 132 132
+ Partials 58 53 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request Summary
Functional Tests
Files Changed
View more in PlayerZero |
e42e99d to
2645b47
Compare
2645b47 to
21fb363
Compare
21fb363 to
603dc64
Compare
551ec3f to
d1b92a2
Compare
d1b92a2 to
d8543e8
Compare
What did you do?
Added
CreateEventAutoConferencingProviderenum for autocreate conferencing providers in event creationCreateEventManualConferencingProviderenum for manual conferencing providers in event creationUpdateEventAutoConferencingProviderenum for autocreate conferencing providers in event updatesUpdateEventManualConferencingProviderenum for manual conferencing providers in event updatesChanged
CreateEventRequest.Conferencingto use dedicated provider enums while maintaining backward compatibilityUpdateEventRequest.Conferencingto use dedicated provider enums while maintaining backward compatibilityDeprecated
CreateEventRequest.Conferencing.Autocreate.fromConferencingProvider()- UseCreateEventAutoConferencingProviderinsteadCreateEventRequest.Conferencing.Details.fromConferencingProvider()- UseCreateEventManualConferencingProviderinsteadUpdateEventRequest.Conferencing.Autocreate.fromConferencingProvider()- UseUpdateEventAutoConferencingProviderinsteadUpdateEventRequest.Conferencing.Details.fromConferencingProvider()- UseUpdateEventManualConferencingProviderinsteadLicense
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.