Skip to content

CUST-4675 added 'Skype for Consumer' and 'Skype for Business' to conferencing providers. #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samuelpx merged 2 commits into from
Aug 14, 2025
Merged

CUST-4675 added 'Skype for Consumer' and 'Skype for Business' to conferencing providers. #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f89873
CUST-4675 added 'Skype for Consumer' and 'Skype for Business' as conf…
samuelpx Aug 14, 2025
719e9b7
CUST-4675 handled 'Skype for Consumer' and 'Skype for Business' cases…
samuelpx Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Nylas Java SDK Changelog

## [Unreleased]

### Added
Copy link
Collaborator

@AaronDDM AaronDDM Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change this to "Fixed" - this is a bug apparently

* `Skype for Consumer` as a conferencing provider to ConferencingProvider
* `Skype for Business` as a conferencing provider to ConferencingProvider

## [2.13.0]

### Added
Expand Down
6 changes: 6 additions & 0 deletions src/main/kotlin/com/nylas/models/ConferencingProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@ enum class ConferencingProvider {
@Json(name = "Zoom Meeting")
ZOOM_MEETING,

@Json(name = "Skype for Consumer")
SKYPE_FOR_CONSUMER,

@Json(name = "Skype for Business")
SKYPE_FOR_BUSINESS,

@Json(name = "unknown")
UNKNOWN,
}
2 changes: 2 additions & 0 deletions src/main/kotlin/com/nylas/models/CreateEventRequest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,8 @@ data class CreateEventRequest(
ConferencingProvider.MICROSOFT_TEAMS -> CreateEventManualConferencingProvider.MICROSOFT_TEAMS
ConferencingProvider.GOTOMEETING -> throw IllegalArgumentException("GoToMeeting is not supported in CreateEventManualConferencingProvider. Use the new enum directly.")
ConferencingProvider.WEBEX -> throw IllegalArgumentException("WebEx is not supported in CreateEventManualConferencingProvider. Use the new enum directly.")
ConferencingProvider.SKYPE_FOR_CONSUMER -> throw IllegalArgumentException("Skype for Consumer is not supported in CreateEventManualConferencingProvider. Use the new enum directly.")
ConferencingProvider.SKYPE_FOR_BUSINESS -> throw IllegalArgumentException("Skype for Business is not supported in CreateEventManualConferencingProvider. Use the new enum directly.")
ConferencingProvider.UNKNOWN -> throw IllegalArgumentException("Unknown provider is not supported for event creation. Use CreateEventManualConferencingProvider instead.")
}
return Details(newProvider, details)
Expand Down
2 changes: 2 additions & 0 deletions src/main/kotlin/com/nylas/models/UpdateEventRequest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,6 +457,8 @@ data class UpdateEventRequest(
ConferencingProvider.MICROSOFT_TEAMS -> UpdateEventManualConferencingProvider.MICROSOFT_TEAMS
ConferencingProvider.GOTOMEETING -> throw IllegalArgumentException("GoToMeeting is not supported in UpdateEventManualConferencingProvider. Use the new enum directly.")
ConferencingProvider.WEBEX -> throw IllegalArgumentException("WebEx is not supported in UpdateEventManualConferencingProvider. Use the new enum directly.")
ConferencingProvider.SKYPE_FOR_CONSUMER -> throw IllegalArgumentException("Skype for Consumer is not supported in UpdateEventManualConferencingProvider. Use the new enum directly.")
ConferencingProvider.SKYPE_FOR_BUSINESS -> throw IllegalArgumentException("Skype for Business is not supported in UpdateEventManualConferencingProvider. Use the new enum directly.")
ConferencingProvider.UNKNOWN -> throw IllegalArgumentException("Unknown provider is not supported for event updates. Use UpdateEventManualConferencingProvider instead.")
}
return Details(newProvider, details)
Expand Down
Loading