-
Notifications
You must be signed in to change notification settings - Fork 123
Upgraded eslint, dropped Node 16.x support. #656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Pull Request SummaryThe pull request introduces several changes focused on code cleanup, linting improvements, and modernizing the codebase. Here's a summary of the key changes:
Overall, these changes aim to improve code quality, maintainability, and developer experience without altering the product's functionality or user experience. Files Changed
View more in PlayerZero |
efa403a to
26a79a2
Compare
26a79a2 to
823284a
Compare
823284a to
d904844
Compare
… and eslint Removes [tmp](https://github.com/raszi/node-tmp). It's no longer used after updating ancestor dependencies [tmp](https://github.com/raszi/node-tmp), [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin), [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) and [eslint](https://github.com/eslint/eslint). These dependencies need to be updated together. Removes `tmp` Updates `@typescript-eslint/eslint-plugin` from 2.34.0 to 8.39.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.39.0/packages/eslint-plugin) Updates `@typescript-eslint/parser` from 2.34.0 to 8.39.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.39.0/packages/parser) Updates `eslint` from 5.16.0 to 9.32.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v5.16.0...v9.32.0) --- updated-dependencies: - dependency-name: tmp dependency-version: dependency-type: indirect - dependency-name: "@typescript-eslint/eslint-plugin" dependency-version: 8.39.0 dependency-type: direct:development - dependency-name: "@typescript-eslint/parser" dependency-version: 8.39.0 dependency-type: direct:development - dependency-name: eslint dependency-version: 9.32.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> upgraded eslint
d904844 to
b5de4eb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #656 +/- ##
=======================================
Coverage 94.87% 94.87%
=======================================
Files 35 35
Lines 781 781
Branches 66 66
=======================================
Hits 741 741
Misses 33 33
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nylas + PlayerZeroView more in PlayerZero |
Removes tmp. It's no longer used after updating ancestor dependencies tmp, @typescript-eslint/eslint-plugin, @typescript-eslint/parser and eslint. These dependencies need to be updated together.
Removes
tmpUpdates
@typescript-eslint/eslint-pluginfrom 2.34.0 to 8.39.0Release notes
Sourced from
@typescript-eslint/eslint-plugin's releases.... (truncated)
Changelog
Sourced from
@typescript-eslint/eslint-plugin's changelog.... (truncated)
Commits
c98d513chore(release): publish 8.39.0a8def4bfix(eslint-plugin): [no-unsafe-assignment] add anunsafeObjectPatternmessa...422e3e2feat(eslint-plugin): [only-throw-error] support yield/await expressions (#11417)e901ad8fix(eslint-plugin): revert #11127 (#11447)8dc8340feat(eslint-plugin): add no-unnecessary-type-conversion to strict-type-checke...2112d58feat: update to TypeScript 5.9.2 (#11445)b872e2bfeat(eslint-plugin): [naming-convention] add enumMember PascalCase default op...757f9eefix(eslint-plugin): [prefer-optional-chain] ignorecheckoption for most RH...5b24864chore: fix dangling reference to generate:configs in comments (#11431)d11e79echore(release): publish 8.38.0Updates
@typescript-eslint/parserfrom 2.34.0 to 8.39.0Release notes
Sourced from
@typescript-eslint/parser's releases.... (truncated)
Changelog
Sourced from
@typescript-eslint/parser's changelog.... (truncated)
Commits
c98d513chore(release): publish 8.39.02112d58feat: update to TypeScript 5.9.2 (#11445)d11e79echore(release): publish 8.38.0816be17chore(release): publish 8.37.084b7a2echore(release): publish 8.36.0e2ecca6chore: fix issues introduced by updatednxconfiguration (#11230)f9bd7d8chore(release): publish 8.35.1d19c9f3chore(release): publish 8.35.0ccd0791chore(release): publish 8.34.18915a47chore(release): publish 8.34.0Updates
eslintfrom 5.16.0 to 9.32.0Release notes
Sourced from eslint's releases.
... (truncated)
Changelog
Sourced from eslint's changelog.
... (truncated)
Commits
23640319.32.0a0e62e2Build: changelog update for 9.32.0960fd40fix: Upgrade@eslint/js(#19971)50de1cechore: package.json update for@eslint/jsreleasebbf23fafix: Refactor reporting into FileReport (#19877)74f01a3ci: unpinjitito version^2.5.1(#19970)d498887fix: bump@eslint/plugin-kitto 0.3.4 to resolve vulnerability (#19965)2ab1381ci: pinjitito version 2.4.2 (#19964)b7f7545test: switch to flat config mode inSourceCodetests (#19953)f5a35e3test: switch to flat config mode in eslint-fuzzer (#19960)Maintainer changes
This version was pushed to npm by eslintbot, a new releaser for eslint since your current version.
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.