-
Notifications
You must be signed in to change notification settings - Fork 123
feat(api): expose raw response headers on all responses via non-enumerable rawHeader #660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rable rawHeaders; keep existing camelCased headers intact - add tests for rawHeaders on responses - update response models to include rawHeaders - attach rawHeaders in API client without breaking equality
Pull Request Summary
Functional Tests
Files Changed
View more in PlayerZero |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #660 +/- ##
=======================================
Coverage 94.87% 94.87%
=======================================
Files 35 35
Lines 781 781
Branches 66 66
=======================================
Hits 741 741
Misses 33 33
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
uriell-keeper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved w/ a non blocking comment, looks good!
What did you do?
Addresses #659
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.