-
Notifications
You must be signed in to change notification settings - Fork 123
fix: resolve CJS build issue causing "TypeError: Nylas is not a constructor" error #665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request SummaryThe pull request introduces several changes aimed at improving the compatibility and developer experience for users of the Nylas SDK, particularly those using CommonJS (CJS) modules. Here are the key changes:
Overall, these changes aim to enhance the developer experience, particularly for those using CommonJS, by providing better type information, improved logging, and more robust examples, while ensuring compatibility and reducing potential errors during development. Files Changed
View more in PlayerZero |
d40af03 to
09f08e6
Compare
09f08e6 to
0d07675
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #665 +/- ##
=======================================
Coverage 94.87% 94.87%
=======================================
Files 35 35
Lines 781 781
Branches 66 66
=======================================
Hits 741 741
Misses 33 33
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0d07675 to
17fd3eb
Compare
What did you do?
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.