Skip to content

Conversation

@AaronDDM
Copy link
Collaborator

@AaronDDM AaronDDM commented Oct 3, 2025

fix: make conferencing property optional in Event model

Closes #678

The conferencing property in the Event interface was incorrectly marked as required, leading to issues when handling events without conferencing details from the API.

This PR makes the conferencing property optional (conferencing?: Conferencing;) in src/models/events.ts to align with the actual API behavior.

New tests have been added in tests/resources/events.spec.ts to verify that events can be correctly handled and created both with and without conferencing information. The CHANGELOG.md has also been updated.

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.


Open in Cursor Open in Web

Co-authored-by: aaron.d <aaron.d@nylas.com>
@cursor
Copy link

cursor bot commented Oct 3, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@codecov
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.42%. Comparing base (a2000bf) to head (d987b07).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #679   +/-   ##
=======================================
  Coverage   96.42%   96.42%           
=======================================
  Files          37       37           
  Lines         812      812           
  Branches       72       72           
=======================================
  Hits          783      783           
  Misses         26       26           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AaronDDM AaronDDM self-assigned this Oct 3, 2025
@AaronDDM AaronDDM marked this pull request as ready for review October 3, 2025 18:55
@playerzero-ai
Copy link

playerzero-ai bot commented Oct 3, 2025

nylas + PlayerZero

Simulations

Project Branch Status Updated (UTC)
nylas cursor/fix-nylas-nodejs-issue-678-with-tests-f0f1 -> main Pass 5/5 passed Oct 03 @ 07:04 PM UTC

Results

@AaronDDM AaronDDM merged commit 9cabe15 into main Oct 5, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

conferencing object on Event should be optional

4 participants