Skip to content

Conversation

@AaronDDM
Copy link
Collaborator

@AaronDDM AaronDDM commented Dec 3, 2025

Fixes #685

This PR enhances the Folders.find method to support optional queryParams.

Why this change?
The existing Folders.find method did not accept queryParams, unlike other resource find methods (e.g., Messages.find, Events.find). This update aligns Folders.find with the SDK's consistent pattern, making it more robust and ready for future API extensions that might introduce query parameters for fetching folders.

Changes include:

  • Added FindFolderQueryParams interface.
  • Updated FindFolderParams to include an optional queryParams property.
  • Modified Folders.find to accept and pass queryParams to the base _find method.
  • Added a new test case to verify find with queryParams.

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.


Open in Cursor Open in Web

Co-authored-by: aaron.d <aaron.d@nylas.com>
@cursor
Copy link

cursor bot commented Dec 3, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

Co-authored-by: aaron.d <aaron.d@nylas.com>
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.42%. Comparing base (2f376fe) to head (9f6fd25).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #686   +/-   ##
=======================================
  Coverage   96.42%   96.42%           
=======================================
  Files          37       37           
  Lines         812      812           
  Branches       72       72           
=======================================
  Hits          783      783           
  Misses         26       26           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: aaron.d <aaron.d@nylas.com>
@AaronDDM AaronDDM marked this pull request as ready for review December 3, 2025 02:32
@AaronDDM AaronDDM changed the title Fix Nylas Node.js issue 685 feat(folders): Updated Folders.find method to support optional queryParams. Dec 3, 2025
@AaronDDM AaronDDM requested review from b3ndoi and radenkovic December 3, 2025 02:34
@AaronDDM AaronDDM merged commit 336bc5f into main Dec 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement GET FOLDER api

4 participants