Skip to content

Validate attachment response and throw error #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AaronDDM merged 7 commits into from
Dec 16, 2024
Merged

Validate attachment response and throw error #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2dc3196
Validate attachment response and throw error
kraju3 Dec 9, 2024
4a410f6
Update nylas/handler/http_client.py
kraju3 Dec 9, 2024
8496d83
Resolve PR comments
kraju3 Dec 9, 2024
c6e1816
Fix pylint warnings
kraju3 Dec 9, 2024
12ee8be
Check the status code before and remove utlity function
kraju3 Dec 16, 2024
0941036
Added changelog
kraju3 Dec 16, 2024
4fd7350
merge main
kraju3 Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ nylas-python Changelog
Unreleased
--------------
* Add support for Scheduler APIs
* Fixed attachment download response handling

v6.4.0
----------------
Expand Down
6 changes: 4 additions & 2 deletions nylas/handler/http_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ def _validate_response(response: Response) -> dict:

return json


def _build_query_params(base_url: str, query_params: dict = None) -> str:
query_param_parts = []
for key, value in query_params.items():
Expand Down Expand Up @@ -109,7 +108,7 @@ def _execute_download_request(
query_params=None,
stream=False,
overrides=None,
) -> Union[bytes, Response]:
) -> Union[bytes, Response,dict]:
request = self._build_request("GET", path, headers, query_params, overrides)

timeout = self.timeout
Expand All @@ -124,6 +123,9 @@ def _execute_download_request(
stream=stream,
)

if not response.ok:
return _validate_response(response)

# If we stream an iterator for streaming the content, otherwise return the entire byte array
if stream:
return response
Expand Down
Loading