Added response headers to all responses from the Nylas API #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronDDM
force-pushed
the
TW-3464-python-add-headers-to-error-responses
branch
from
a231dc7 to
1e398a8
Compare
kraju3
reviewed
Jan 28, 2025
Contributor
kraju3
left a comment
kraju3
left a comment
There was a problem hiding this comment.
I only see some resource endpoints. Do we have support for this in threads endpoints?
Contributor
Author
Because threads uses the underlying resources class, it automatically gets this support. Files that didn't do that needed to be updated individually. |
kraju3
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Nylas has added a new
retry-headerthat will be included as part of our error responses. This PR exposes these response headers for all success and error responses.License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.