-
Notifications
You must be signed in to change notification settings - Fork 82
[CUST-4448] Fix: content id not being respected for large inline attachments. #440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Modified _build_form_request to use content_id as field name when provided
- Falls back to file{index} naming when content_id is not specified
- Maintains full backward compatibility for existing attachments
- Added comprehensive tests for content_id handling
- Added example demonstrating inline attachment usage with content_id
- Updated CHANGELOG.md
Fixes issue where large inline attachments (>3MB) ignored content_id
and used generic file{index} names, breaking inline image references
in HTML emails.
Removed conflicting duplicate assertions in test_build_form_request_backwards_compatibility that were causing test failures.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #440 +/- ##
==========================================
- Coverage 98.85% 98.73% -0.13%
==========================================
Files 45 52 +7
Lines 1753 2289 +536
==========================================
+ Hits 1733 2260 +527
- Misses 20 29 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request SummarySummary of what's changing and why (CUST-4448)
Product / functionality impact
Developer / UX improvements
Tests
Operational notes / caveats
Net effect
Files ChangedView more in PlayerZero |
- Replace placeholder binary data with actual PNG image base64 data - Use proper base64 decoding for both small and large image examples - Add base64 import to handle image decoding - Maintain example functionality while using realistic image data
samLRodrigues
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What did you do?
_build_form_requestto usecontent_idif exists, otherwise fallback to indexed file#License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.