tst_stringsorter.qml -> doNotIgnorePunctuation fallback#50
Open
rzerres wants to merge 1 commit intooKcerG:masterfrom
Open
tst_stringsorter.qml -> doNotIgnorePunctuation fallback#50rzerres wants to merge 1 commit intooKcerG:masterfrom
rzerres wants to merge 1 commit intooKcerG:masterfrom
Conversation
* Qt5 on linux does not support ICU per default anymore * Apple Platforms do not support ICU * got no clue, on howto reliable check puctuation support at complile time, sorter.h: 'doNotIgnorePunctuation' is not respected on the majority of target systems. To let tests pass, comment in source and fallback to 'doIgnorPuctuation'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
as explained in the commit, on Linux and Apple based Systems Qt5 is not supporting ICU.
The out of the box test will fail for doNotIgnorePunctuation. I have no clue, on howto use a preprocessor check at buildtime to get arround other then comment out and fall back to do IgnorePuctuation.
Cheers
Ralf