Configure builder by default by ptrus · Pull Request #657 · oasisprotocol/cli

ptrus · 2025-11-27T12:01:53Z

Fixes: #652

This PR configures the ROFL builder container image by default for new and upgraded ROFL apps. Also provides clearer error messages when the container runtime is missing or native builds aren't supported.

Everyone should now just run oasis rofl build (regardless of platform).

Note: This changes the built artifacts again, but builds should now be fully reproducible across environments when using the Docker builder.

Changes:

Builder container image is now configured by default for new and upgraded apps
Stream tar directly to sqfstar instead of extracting to disk
Split builder images: minimal rofl-container-builder for container apps, full rofl-dev for raw Rust apps

Tested this (and got reproducable builts on):

ubuntu with oasis rofl build --no-container (no builder)
ubuntu with oasis rofl build (uses builder)
macos with builder oasis rofl build (uses builder)

TODO:

Consider adding a CLI version field to the manifest (set on init/upgrade) to track which CLI version created/modified it.
update quickstart docs to not recommend docker run --platform linux/amd64 --volume .:/src -it ghcr.io/oasisprotocol/rofl-dev:main oasis rofl build anymore, once this is released
- done in docs/rofl: Simplify rofl build instructions oasis-sdk#2411

netlify · 2025-11-27T12:01:59Z

✅ Deploy Preview for oasisprotocol-cli canceled.

Name	Link
🔨 Latest commit	`3cbaa26`
🔍 Latest deploy log	https://app.netlify.com/projects/oasisprotocol-cli/deploys/69380d8d8a51e90008324608

build/rofl/artifacts.go

kostko · 2025-11-28T08:50:58Z

since rofl-dev image will now be more widely used, we might want to see if there's an easy way to reduce the size of it a bit

We could split it into two images, one that has the essential build tools for container-based apps (should be small) and the other that has Rust toolchain and more stuff. Then use the appropriate one when initializing/upgrading, depending on app kind (raw vs. container).

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cmd/rofl/common/manifest_test.go

cmd/rofl/build/artifacts.go

cmd/rofl/build/build.go

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cmd/rofl/common/manifest_test.go

cmd/rofl/build/scripts.go

cmd/rofl/build/artifacts.go

kostko

Nice work!

kostko · 2025-12-05T09:06:54Z

cmd/rofl/build/artifacts.go

 		return fmt.Errorf("%w\n%s", err, out.String())
 	}

+	// Resize to ensure virtual size matches original (prevents truncation).


Was this also a problem before?

It wasn't, but it's not 100% clear to me why. Maybe this is just a problem on macos, before we always used a docker container for building on macos. Will test out if this is macos specific.

I figured out what the issue was. It wasn't related to the environment. The problem was that the padding was done on the host via f.Truncate (not in the builder container), and over the bind mount the container saw only the pre‑pad size. Doing either veritysetup verify or resizing the image fixed the issue (probably just due to touching it?). So I moved the padding to be run in the builder env and it fixes the issue. I have kept the veritysetup verify step, since it's useful as a sanity check, but have removed the resize since it's not needed.

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ptrus mentioned this pull request Nov 27, 2025

oasis rofl build without builder should just fail on macOS #652

Closed

ptrus force-pushed the ptrus/feature/builder-artefact-default branch 3 times, most recently from 45f5d20 to 6969fc1 Compare November 28, 2025 06:59

ptrus marked this pull request as ready for review November 28, 2025 07:01

ptrus requested review from Copilot, kostko and matevz November 28, 2025 07:03

Copilot started reviewing on behalf of ptrus November 28, 2025 07:03 View session

Copilot finished reviewing on behalf of ptrus November 28, 2025 07:03

ptrus commented Nov 28, 2025

View reviewed changes

build/rofl/artifacts.go Outdated Show resolved Hide resolved

ptrus force-pushed the ptrus/feature/builder-artefact-default branch 8 times, most recently from 53cc085 to 9a01701 Compare November 28, 2025 08:49

Copilot AI reviewed Nov 28, 2025

View reviewed changes

ptrus marked this pull request as draft November 28, 2025 09:26

ptrus force-pushed the ptrus/feature/builder-artefact-default branch 7 times, most recently from 6898807 to ca91721 Compare December 2, 2025 08:59

ptrus force-pushed the ptrus/feature/builder-artefact-default branch from 77537f4 to dc2e526 Compare December 2, 2025 14:24

ptrus requested a review from Copilot December 2, 2025 14:24

Copilot started reviewing on behalf of ptrus December 2, 2025 14:25 View session

Copilot finished reviewing on behalf of ptrus December 2, 2025 14:29

ptrus force-pushed the ptrus/feature/builder-artefact-default branch from dc2e526 to 3956608 Compare December 2, 2025 14:31

Copilot AI reviewed Dec 2, 2025

View reviewed changes

cmd/rofl/common/manifest_test.go Show resolved Hide resolved

cmd/rofl/build/artifacts.go Show resolved Hide resolved

cmd/rofl/build/artifacts.go Outdated Show resolved Hide resolved

cmd/rofl/build/build.go Outdated Show resolved Hide resolved

ptrus requested a review from Copilot December 2, 2025 14:31

Copilot started reviewing on behalf of ptrus December 2, 2025 14:32 View session

ptrus force-pushed the ptrus/feature/builder-artefact-default branch from 3956608 to 7b86931 Compare December 2, 2025 14:34

Copilot finished reviewing on behalf of ptrus December 2, 2025 14:37

Copilot AI reviewed Dec 2, 2025

View reviewed changes

cmd/rofl/common/manifest_test.go Show resolved Hide resolved

cmd/rofl/build/scripts.go Outdated Show resolved Hide resolved

cmd/rofl/build/artifacts.go Show resolved Hide resolved

ptrus force-pushed the ptrus/feature/builder-artefact-default branch 2 times, most recently from 97cf10c to cfb1131 Compare December 2, 2025 15:38

ptrus mentioned this pull request Dec 2, 2025

docs/rofl: Simplify rofl build instructions oasisprotocol/oasis-sdk#2411

Merged

Configure builder by default

a089bd1

ptrus force-pushed the ptrus/feature/builder-artefact-default branch 6 times, most recently from 0ae0114 to b420dc1 Compare December 4, 2025 10:49

kostko approved these changes Dec 5, 2025

View reviewed changes

ptrus force-pushed the ptrus/feature/builder-artefact-default branch from b420dc1 to 4274023 Compare December 9, 2025 11:48

rofl/build: Stream tar directly to sqfstar without extraction

3cbaa26

ptrus force-pushed the ptrus/feature/builder-artefact-default branch from 4274023 to 3cbaa26 Compare December 9, 2025 11:52

ptrus requested a review from Copilot December 9, 2025 11:59

Copilot started reviewing on behalf of ptrus December 9, 2025 12:00 View session

Copilot AI reviewed Dec 9, 2025

View reviewed changes

ptrus merged commit 1323206 into master Dec 9, 2025
13 checks passed

ptrus deleted the ptrus/feature/builder-artefact-default branch December 9, 2025 12:04

Comments

Conversation

ptrus commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for oasisprotocol-cli canceled.

Uh oh!

Uh oh!

kostko commented Nov 28, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kostko left a comment

Choose a reason for hiding this comment

Uh oh!

kostko Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

ptrus Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

ptrus Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ptrus commented Nov 27, 2025 •

edited

Loading

netlify bot commented Nov 27, 2025 •

edited

Loading

ptrus Dec 9, 2025 •

edited

Loading