-
Notifications
You must be signed in to change notification settings - Fork 0
[WIP] Fix action step issue in workflow #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Fix action step issue in workflow #239
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…yaml - Remove references to @objectstack/spec, @objectstack/runtime, @objectstack/objectql, @objectstack/core - Remove ../spec/packages/* and packages/objectstack/* from pnpm-workspace.yaml - Update pnpm-lock.yaml to reflect clean dependencies Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
bb4651c
into
copilot/fix-runtimeplugin-issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR attempts to fix pnpm lockfile synchronization issues by removing non-existent workspace dependencies. The changes remove references to @objectstack/* packages from package.json files and remove the external workspace path ../spec/packages/* from pnpm-workspace.yaml.
Changes:
- Removed workspace references to external
@objectstack/*packages from all package.json files - Removed
../spec/packages/*andpackages/objectstack/*paths from pnpm-workspace.yaml - Updated pnpm-lock.yaml to remove entries for the external workspace packages
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Removed external workspace paths for non-existent packages |
| pnpm-lock.yaml | Removed lockfile entries for @objectstack/* external workspace packages |
| packages/foundation/types/package.json | Removed @objectstack/spec and @objectstack/runtime dependencies |
| packages/foundation/core/package.json | Removed @objectstack/spec, @objectstack/runtime, @objectstack/objectql, and @objectstack/core dependencies |
| packages/foundation/platform-node/package.json | Removed @objectstack/spec dependency |
| packages/foundation/plugin-security/package.json | Removed @objectstack/spec and @objectstack/runtime dependencies |
| packages/drivers/*/package.json | Removed @objectstack/spec dependency from multiple driver packages |
| package.json | Removed @objectstack/* dependencies from root package.json |
| examples/*/package.json | Removed @objectstack/* dependencies from example packages |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
| }, | ||
| "dependencies": { | ||
| "@objectstack/runtime": "workspace:*", | ||
| "@objectql/types": "workspace:*", |
Copilot
AI
Jan 29, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The source code in packages/foundation/core/src still contains imports from @objectstack/spec, @objectstack/runtime, @objectstack/objectql, and @objectstack/core packages that have been removed from this package.json. These imports will cause build failures. The following files need to be updated:
- src/index.ts: imports from @objectstack/runtime, @objectstack/objectql, and @objectstack/spec
- src/app.ts: imports from @objectstack/core and @objectstack/objectql
- src/repository.ts: imports from @objectstack/runtime and @objectstack/spec
- src/plugin.ts: imports from @objectstack/core
- src/validator-plugin.ts: imports from @objectstack/core
- src/formula-plugin.ts: imports from @objectstack/core
- src/query/*.ts files: import from @objectstack/spec
Either the removed dependencies need to be restored, or the code needs to be refactored to remove these imports.
| "@objectql/types": "workspace:*", | |
| "@objectql/types": "workspace:*", | |
| "@objectstack/spec": "workspace:*", | |
| "@objectstack/runtime": "workspace:*", | |
| "@objectstack/objectql": "workspace:*", | |
| "@objectstack/core": "workspace:*", |
| @@ -22,7 +22,6 @@ | |||
| "dependencies": { | |||
| "@objectql/core": "workspace:*", | |||
| "@objectql/types": "workspace:*", | |||
Copilot
AI
Jan 29, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The source code in packages/foundation/platform-node/src/plugin.ts imports from @objectstack/spec package that has been removed from this package.json. This import will cause build failures. Either the dependency needs to be restored or the code needs to be refactored to remove this import.
| "@objectql/types": "workspace:*", | |
| "@objectql/types": "workspace:*", | |
| "@objectstack/spec": "workspace:*", |
| }, | ||
| "peerDependencies": {}, | ||
| "dependencies": {}, | ||
| "devDependencies": { |
Copilot
AI
Jan 29, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The source code in packages/foundation/types/src still contains imports from @objectstack/spec and @objectstack/objectql packages that have been removed from this package.json. These imports will cause build failures. The following files need to be updated:
- src/action.ts: imports from @objectstack/spec
- src/field.ts: imports from @objectstack/spec
- src/object.ts: imports from @objectstack/spec
- src/query.ts: imports from @objectstack/spec
- src/config.ts: imports from @objectstack/objectql
Either the removed dependencies need to be restored, or the code needs to be refactored to remove these imports.
| "devDependencies": { | |
| "devDependencies": { | |
| "@objectstack/spec": "workspace:*", | |
| "@objectstack/objectql": "workspace:*", |
| - packages/protocols/* | ||
| - ../spec/packages/* | ||
| - examples/quickstart/* |
Copilot
AI
Jan 29, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description states this is fixing pnpm lockfile synchronization by removing "non-existent workspace dependencies." However, the removed packages (@objectstack/spec, @objectstack/runtime, @objectstack/objectql, @objectstack/core) are still being imported and used in the source code across multiple packages. This creates a critical discrepancy:
- The dependencies were removed from package.json files
- The pnpm-workspace.yaml was updated to remove the external workspace path
../spec/packages/* - But the TypeScript source code still has active imports from these packages
This will cause build failures. The PR needs to either:
- Restore these dependencies if they are published npm packages
- Or refactor the code to remove all imports from these packages before removing the dependencies
Based on the custom coding guidelines, this violates the "Strict Spec Adherence" principle - there's a mismatch between the specification (package.json dependencies) and the implementation (code imports).
Fix pnpm lockfile synchronization (Minimal Fix)
@objectstack/runtimefrom protocol plugins but forgot to update pnpm-lock.yaml@objectstack/spec,@objectstack/runtime,@objectstack/objectql,@objectstack/core)pnpm install --no-frozen-lockfileto update the lockfileOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.