-
Notifications
You must be signed in to change notification settings - Fork 0
Verify non-standard component extraction and fix lockfile dependencies #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify non-standard component extraction and fix lockfile dependencies #213
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
📦 Bundle Size Report
Size Limits
|
|
✅ All checks passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
| specifier: 19.2.9 | ||
| version: 19.2.9 | ||
| '@types/react-dom': | ||
| specifier: 19.0.3 | ||
| version: 19.0.3(@types/react@19.0.6) | ||
| specifier: 19.2.3 | ||
| version: 19.2.3(@types/react@19.2.9) |
Copilot
AI
Jan 26, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lockfile specifies @types/react version 19.2.9 and @types/react-dom version 19.2.3, but the corresponding package.json file at packages/plugin-calendar-view/package.json still has the old versions (^19.0.6 and ^19.0.3). This creates an inconsistency between the lockfile and package.json.
All other plugin packages (plugin-chatbot, plugin-timeline, plugin-aggrid, plugin-kanban) have their package.json files updated to use ^19.2.9 and ^19.2.3. The package.json for plugin-calendar-view should be updated to match this pattern for consistency.
| lucide-react@0.468.0: | ||
| resolution: {integrity: sha512-6koYRhnM2N0GGZIdXzSeiNwguv1gt/FAjZOiPl76roBi3xKEXa4WmfpxgQwTTL4KipXjefrnf3oV4IsYhi4JFA==} | ||
| peerDependencies: | ||
| react: 19.2.3 | ||
|
|
Copilot
AI
Jan 26, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plugin-calendar-view package uses lucide-react@^0.468.0, while other packages in the monorepo (including @object-ui/components and @object-ui/plugin-chatbot) use the newer lucide-react@^0.563.0. This version inconsistency could lead to duplicate dependencies in consuming applications and increases bundle size. Unless there's a specific compatibility reason, all packages should use the same version of lucide-react for consistency.
| specifier: 19.2.9 | ||
| version: 19.2.9 | ||
| '@types/react-dom': | ||
| specifier: 19.0.3 | ||
| version: 19.0.3(@types/react@19.0.6) | ||
| specifier: 19.2.3 | ||
| version: 19.2.3(@types/react@19.2.9) |
Copilot
AI
Jan 26, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description states "Updated pnpm-lock.yaml to resolve @types/react and @types/react-dom version mismatches in plugin-calendar-view", but the underlying package.json file at packages/plugin-calendar-view/package.json was not updated to match. The lockfile now specifies versions 19.2.9 and 19.2.3, while the package.json still declares ^19.0.6 and ^19.0.3. To fully resolve the version mismatch, the package.json file needs to be updated as well.
Summary
Audited
packages/components/src/uito ensure only standard Shadcn primitives remain. Complex business components (chatbot,timeline,calendar-view) were already extracted to plugin packages in prior work. This PR verifies the implementation and fixes dependency mismatches.Verification Results
Components Properly Extracted:
chatbot.tsx→@object-ui/plugin-chatbottimeline.tsx→@object-ui/plugin-timelinecalendar-view.tsx→@object-ui/plugin-calendar-viewAll use package imports (
@object-ui/components) instead of relative paths. Exports removed from core index.Non-Standard Components Remaining (Intentional):
button-group,combobox,date-picker,field,filter-builder,input-groupempty,item,kbd,spinner,toasterThese are utility abstractions over Shadcn primitives, not business logic.
Changes
pnpm-lock.yamlto resolve@types/reactand@types/react-domversion mismatches inplugin-calendar-viewBuild Status
✓ All packages build successfully:
@object-ui/components@object-ui/plugin-chatbot@object-ui/plugin-timelineOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.