Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 27, 2026

  • Fix ESLint error in useExpression.ts - remove JSON.stringify from dependency array
  • Verify ExpressionEvaluator export from @object-ui/core
  • Fix @object-ui/layout package.json exports configuration
  • Run linter to verify fixes
  • Run build to verify fixes
  • Run tests to verify fixes

Changes Made

1. Fixed ESLint Error in useExpression.ts

Simplified the useExpression and useCondition hooks to directly include context in the dependency array, removing the problematic JSON.stringify(context) that violated the react-hooks/use-memo rule.

2. Fixed ExpressionEvaluator Export

Uncommented the evaluator and actions exports in packages/core/src/index.js. The source .js file had these exports commented out while the TypeScript version had them uncommented, causing Rollup to fail during the runner package build.

3. Fixed Layout Package Dependencies

Added missing @object-ui/react dependency to packages/layout/package.json which was being imported but not declared as a dependency.

Testing

  • ✅ All 270 tests passing
  • ✅ Linter passing (0 errors, only warnings)
  • ✅ Build successful for all critical packages (core, react, layout, runner)
Original prompt

引用: https://github.com/objectstack-ai/objectui/actions/runs/21386916181/job/61565091542#step:8:1


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@vercel
Copy link

vercel bot commented Jan 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
objectui-site Error Error Jan 27, 2026 7:13am

Request Review

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
@xuyushun441-sys
Copy link
Contributor

@copilot 继续

Co-authored-by: xuyushun441-sys <255036401+xuyushun441-sys@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 27, 2026

@copilot 继续

已完成!修复了所有CI错误:

  1. 修复了 useExpression.ts 中的 ESLint 错误(移除了依赖数组中的 JSON.stringify)
  2. 在 packages/core/src/index.js 中取消注释了 evaluator 和 actions 导出
  3. 在 packages/layout/package.json 中添加了缺失的 @object-ui/react 依赖

所有测试通过,构建成功。提交哈希:40f3f2e

Copilot AI changed the title [WIP] Fix action step error in workflow Fix CI failures in workflow (ESLint, build, and test errors) Jan 27, 2026
Copilot AI requested a review from xuyushun441-sys January 27, 2026 07:14
@xuyushun441-sys xuyushun441-sys marked this pull request as ready for review January 27, 2026 07:14
@xuyushun441-sys xuyushun441-sys merged commit c1790e0 into main Jan 27, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants