Open
Conversation
Add remove_last_filter function with additional feedback message
dexeonify
added a commit
to dexeonify/mpv-config
that referenced
this pull request
Jan 13, 2024
Another approach to occivink/mpv-scripts#77 The code for removing the last crop filter is already in toggle_crop(), I just have to break it down into smaller functions. Firstly, remove_delogo() is invoked to remove the last delogo filter. If a delogo filter exists, the function will remove it and return true; remove_hard() won't be called. Conversely, if no delogo filter is found, remove_hard() is invoked to determine the state of video-crop. Finally, if no delogo filter is present or video-crop is disabled, toggle_crop() will call start_crop(). The order of crop removal will be made configurable in the next few commits.
bashirmhmdi
approved these changes
Mar 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add remove_last_filter function with additional feedback message
Fixes: #76