Open
Conversation
Reference lutim/framapic service
Owner
|
Thanks, I will accept the pull request once Thor77/screencloud-lutim#3 is merged. |
Thor77
reviewed
Aug 10, 2019
plugin-list.xml
Outdated
| <shortname>lutim</shortname> | ||
| <description>Upload to your Lutim instance</description> | ||
| <author>Thor77</author> | ||
| <version>2.1.0</version> |
There was a problem hiding this comment.
Latest version is now 2.2.1 (including the linked PR and a requests dependency update)
Author
There was a problem hiding this comment.
Hello
Thanks a lot, i've updated PR with this new version
A new release was just published \o/
Author
|
Hello Can you merge this PR. Looks good now :) |
olav-st
requested changes
Aug 19, 2019
Owner
olav-st
left a comment
olav-st
left a comment
There was a problem hiding this comment.
The <name> tag must match the <name> tag in https://github.com/Thor77/screencloud-lutim/blob/master/metadata.xml
Follow olav recommendation Co-Authored-By: Olav Sortland Thoresen <olav.s.th@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference lutim/framapic service