-
-
Notifications
You must be signed in to change notification settings - Fork 62
Improve parameter kind handling for argument requirement determination #756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mauvilsa
merged 14 commits into
omni-us:main
from
MilkClouds:improve-parameter-kind-handling
Aug 18, 2025
Merged
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
37d67a8
Improve parameter kind handling for argument requirement determination
MilkClouds 32b2f8c
Fix handling of parameters with kind=None
MilkClouds 2792b91
Update CHANGELOG.rst for PR #756 and add test coverage
MilkClouds 949e1ce
feat: rename is_option into is_non_positional
MilkClouds 82158d0
Move #756 to fixed in changelog
MilkClouds eed540a
Update jsonargparse_tests/test_signatures.py
MilkClouds f3d20ff
Update jsonargparse_tests/test_signatures.py
MilkClouds f0ebb05
Update jsonargparse_tests/test_signatures.py
MilkClouds b308963
Update jsonargparse_tests/test_signatures.py
MilkClouds 247e63b
Fixed test to work for all argument, positional to keyword
MilkClouds 1f9b22e
Removed unreachable if in signature
MilkClouds 752d937
Apply suggestions from code review
mauvilsa 17068dd
Update jsonargparse_tests/test_signatures.py
mauvilsa f2b2dc7
Update jsonargparse/_signatures.py
mauvilsa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MilkClouds marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.