Skip to content

Conversation

@mauvilsa
Copy link
Member

@mauvilsa mauvilsa commented Aug 15, 2025

What does this PR do?

Fixes #755

Before submitting

  • Did you read the contributing guideline?
  • Did you update the documentation? (readme and public docstrings)
  • Did you write unit tests such that there is 100% coverage on related code? (required for bug fixes and new features)
  • Did you verify that new and existing tests pass locally?
  • Did you make sure that all changes preserve backward compatibility?
  • Did you update the CHANGELOG with the pull request link? (not for typos, docs, test updates, or minor internal changes/refactors)

@mauvilsa mauvilsa added the enhancement New feature or request label Aug 15, 2025
@mauvilsa
Copy link
Member Author

@E1k3 please try this out to help identify issues and possible edge cases. Later I will probably add more tests and will update the documentation.

@codecov
Copy link

codecov bot commented Aug 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (0177681) to head (ae39652).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #758   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         6895      6920   +25     
=========================================
+ Hits          6895      6920   +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mauvilsa mauvilsa force-pushed the issue-755-instance-factory-callable-protocols branch from d88d0ce to ae39652 Compare August 18, 2025 05:17
@sonarqubecloud
Copy link

@mauvilsa mauvilsa marked this pull request as ready for review August 18, 2025 05:21
@mauvilsa
Copy link
Member Author

@E1k3 I have now added documentation changes and one more test.

@mauvilsa
Copy link
Member Author

Merging this. Anyway people can comment here, and if there is a need to fix, then it can be done in a separate pull request.

@mauvilsa mauvilsa merged commit bde53d9 into main Aug 19, 2025
31 checks passed
@mauvilsa mauvilsa deleted the issue-755-instance-factory-callable-protocols branch August 19, 2025 10:02
@E1k3
Copy link

E1k3 commented Aug 20, 2025

@E1k3 please try this out to help identify issues and possible edge cases. Later I will probably add more tests and will update the documentation.

Wow that was fast. I was on vacation until today, but I will use this feature in my code and also maybe try some more obscure use cases and let you know if I run into any problems.

Thank you for your work! Jsonargparse might be the best part about working with Lightning for me and will probably also replace standard argparse in most of my personal projects in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow partial application with keyword arguments

3 participants