-
-
Notifications
You must be signed in to change notification settings - Fork 62
Add support callable protocols for instance factory dependency injection #758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@E1k3 please try this out to help identify issues and possible edge cases. Later I will probably add more tests and will update the documentation. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #758 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 6895 6920 +25
=========================================
+ Hits 6895 6920 +25 ☔ View full report in Codecov by Sentry. |
d88d0ce to
ae39652
Compare
|
|
@E1k3 I have now added documentation changes and one more test. |
|
Merging this. Anyway people can comment here, and if there is a need to fix, then it can be done in a separate pull request. |
Wow that was fast. I was on vacation until today, but I will use this feature in my code and also maybe try some more obscure use cases and let you know if I run into any problems. Thank you for your work! Jsonargparse might be the best part about working with Lightning for me and will probably also replace standard argparse in most of my personal projects in the future. |



What does this PR do?
Fixes #755
Before submitting