Backup flow UI updates, Settings UI updates #1230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR SummaryEnhanced the backup flow UI by updating icons, color schemes and typography. Replaced old icons with new modern designs, standardized color usage to match app theme, and switched font from Montserrat to Inter across multiple screens. Improved visual hierarchy and consistency in backup and device management screens. Changes
autogenerated by presubmit.ai |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (22)
- 96599a3: Backup UI updates
- bf6aa57: Backup UI updates
- 4e0fc55: Backup UI updates
- 8997d09: Backup UI updates
- 050b780: Restore failed UI
- 980bbeb: Restore failed UI
- 7e0a04f: Restore failed UI
- 4ca9c79: Merge
- 06789c2: Restore failed UI
- dfb4d8f: Icons
- dbe5dc8: Icons
- 02be6af: Updating green colors
- 8e9741a: Updating green colors
- ec9c4a1: Adjust color scheme
- e0538a9: Import account UI
- 105e644: Import account UI
- f8b799e: Import account UI
- bc563fd: Import account UI
- 6c57886: Import account UI
- 35afcee: Import flow UI
- aca8d96: Import flow UI changes
- d1f2d89: Import flow UI changes
Files Processed (17)
- app/src/main/java/com/flowfoundation/wallet/page/backup/model/BackupType.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/backup/multibackup/fragment/BackupStartFragment.kt (1 hunk)
- app/src/main/res/drawable/bg_mnemonic_index.xml (1 hunk)
- app/src/main/res/drawable/ic_alert_octagon.xml (1 hunk)
- app/src/main/res/drawable/ic_circle_right_green.xml (1 hunk)
- app/src/main/res/drawable/ic_phrase_copy.xml (1 hunk)
- app/src/main/res/layout/activity_devices.xml (2 hunks)
- app/src/main/res/layout/activity_restore_key_store.xml (1 hunk)
- app/src/main/res/layout/fragment_backup_seed_phrase_info.xml (3 hunks)
- app/src/main/res/layout/fragment_backup_seed_phrase_warning.xml (3 hunks)
- app/src/main/res/layout/fragment_backup_start.xml (5 hunks)
- app/src/main/res/layout/fragment_backup_start_about.xml (2 hunks)
- app/src/main/res/layout/fragment_restore_error.xml (3 hunks)
- app/src/main/res/layout/layout_backup_info_item.xml (5 hunks)
- app/src/main/res/layout/layout_device_info_item.xml (4 hunks)
- app/src/main/res/values-night/colors.xml (2 hunks)
- app/src/main/res/values/strings.xml (6 hunks)
Actionable Comments (1)
-
app/src/main/java/com/flowfoundation/wallet/page/backup/multibackup/fragment/BackupStartFragment.kt [38-43]
possible issue: "Important educational UI element removed"
Skipped Comments (2)
-
app/src/main/java/com/flowfoundation/wallet/page/backup/model/BackupType.kt [7-12]
enhancement: "Consider using distinct icons for different backup types"
-
app/src/main/res/layout/fragment_restore_error.xml [130-134]
possible issue: "Button text may be misleading"
Comment on lines
38
to
43
| btnNext.setOnClickListener { | ||
| backupViewModel.startBackup() | ||
| } | ||
| tvLearnMore.setOnClickListener { | ||
| BackupAboutDialog().show(childFragmentManager, BackupAbout.ABOUT_MULTI_BACKUP) | ||
| } | ||
| if (BackupListManager.hadBackupOption(BackupType.GOOGLE_DRIVE)) { | ||
| oiGoogleDrive.changeItemStatus(true) | ||
| } else { |
There was a problem hiding this comment.
The removal of the 'Learn More' button and dialog reduces user access to important information about multi-backup functionality. Consider keeping this educational element or integrating it in a different way to ensure users understand the backup process.
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- 10517e1: Backup UI updates
Files Processed (30)
- app/src/main/java/com/flowfoundation/wallet/page/backup/model/BackupType.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/backup/multibackup/fragment/BackupStartFragment.kt (1 hunk)
- app/src/main/res/drawable/bg_mnemonic_index.xml (1 hunk)
- app/src/main/res/drawable/ic_alert_octagon.xml (1 hunk)
- app/src/main/res/drawable/ic_circle_right_green.xml (1 hunk)
- app/src/main/res/drawable/ic_phrase_copy.xml (1 hunk)
- app/src/main/res/layout/activity_about.xml (1 hunk)
- app/src/main/res/layout/activity_claim_domain.xml (2 hunks)
- app/src/main/res/layout/activity_collection.xml (1 hunk)
- app/src/main/res/layout/activity_developer_mode_setting.xml (1 hunk)
- app/src/main/res/layout/activity_devices.xml (2 hunks)
- app/src/main/res/layout/activity_enable_evm.xml (2 hunks)
- app/src/main/res/layout/activity_nft_detail.xml (1 hunk)
- app/src/main/res/layout/activity_raw_key_restore.xml (1 hunk)
- app/src/main/res/layout/activity_restore_key_store.xml (1 hunk)
- app/src/main/res/layout/activity_token_detail.xml (1 hunk)
- app/src/main/res/layout/activity_wallet_confirm.xml (1 hunk)
- app/src/main/res/layout/activity_wallet_restore.xml (1 hunk)
- app/src/main/res/layout/activity_wallet_setting.xml (1 hunk)
- app/src/main/res/layout/dialog_add_collection_confirm.xml (1 hunk)
- app/src/main/res/layout/dialog_evm_account.xml (1 hunk)
- app/src/main/res/layout/dialog_evm_sign_typed_data.xml (1 hunk)
- app/src/main/res/layout/dialog_evm_transaction.xml (1 hunk)
- app/src/main/res/layout/dialog_fcl_authn.xml (1 hunk)
- app/src/main/res/layout/dialog_fcl_authz.xml (1 hunk)
- app/src/main/res/layout/dialog_fcl_sign_message.xml (1 hunk)
- app/src/main/res/layout/dialog_fcl_wrong_network.xml (1 hunk)
- app/src/main/res/layout/dialog_move_token.xml (1 hunk)
- app/src/main/res/layout/fragment_backup_pin_code.xml (1 hunk)
- app/src/main/res/layout/fragment_backup_seed_phrase_info.xml (3 hunks)
Actionable Comments (0)
Skipped Comments (3)
-
app/src/main/java/com/flowfoundation/wallet/page/backup/model/BackupType.kt [7-12]
enhancement: "Inconsistent icon resource usage across backup types"
-
app/src/main/res/layout/activity_restore_key_store.xml [14-14]
best practice: "Color reference should use semantic naming"
-
app/src/main/res/layout/fragment_backup_seed_phrase_info.xml [102-135]
enhancement: "Warning message accessibility improvement needed"
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (1)
- cb8a1e2: Backup UI updates
Files Processed (3)
- app/src/main/java/com/flowfoundation/wallet/page/profile/subpage/wallet/device/detail/DeviceInfoActivity.kt (1 hunk)
- app/src/main/res/layout/activity_create_device_backup.xml (1 hunk)
- app/src/main/res/layout/activity_device_info.xml (9 hunks)
Actionable Comments (1)
-
app/src/main/java/com/flowfoundation/wallet/page/profile/subpage/wallet/device/detail/DeviceInfoActivity.kt [66-66]
possible bug: "Potential display issue with location formatting"
Skipped Comments (1)
-
app/src/main/res/layout/activity_device_info.xml [301-303]
maintainability: "Redundant color attribute specification"
| tvDeviceName.text = deviceModel.device_name | ||
| tvDeviceApplication.text = deviceModel.user_agent | ||
| tvDeviceIp.text = deviceModel.ip | ||
| tvDeviceLocation.text = deviceModel.city + ", " + deviceModel.countryCode |
There was a problem hiding this comment.
The location string concatenation deviceModel.city + ", " + deviceModel.countryCode may display incorrectly if either city or countryCode is null or empty. Consider adding null checks or using string templates with safe calls:
"${deviceModel.city?.takeIf { it.isNotEmpty() }}${if (deviceModel.city?.isNotEmpty() == true && deviceModel.countryCode?.isNotEmpty() == true) ", " else ""}${deviceModel.countryCode}".trim()
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- 0660f44: Backup UI
Files Processed (4)
- app/src/main/res/drawable/ic_device_backup_start.xml (1 hunk)
- app/src/main/res/drawable/ic_multi_backup_start.xml (1 hunk)
- app/src/main/res/drawable/ic_recovery_phrase_backup_start.xml (1 hunk)
- app/src/main/res/layout/activity_wallet_backup.xml (4 hunks)
Actionable Comments (0)
Skipped Comments (3)
-
app/src/main/res/drawable/ic_device_backup_start.xml [20-20]
enhancement: "Improve accessibility by adding content description"
-
app/src/main/res/layout/activity_wallet_backup.xml [47-50]
best practice: "Missing content description on ImageView"
-
app/src/main/res/layout/activity_wallet_backup.xml [125-125]
maintainability: "Hardcoded text size value"
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- 2f929cb: Backup UI
Files Processed (0)
Actionable Comments (0)
Skipped Comments (0)
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (1)
- a25efa1: Backup UI
Files Processed (1)
- app/src/main/res/layout/activity_devices.xml (3 hunks)
Actionable Comments (1)
-
app/src/main/res/layout/activity_devices.xml [36-36]
possible issue: "Font resource path may be incorrect"
Skipped Comments (0)
| android:layout_marginHorizontal="10dp" | ||
| android:layout_marginTop="8dp" | ||
| android:fontFamily="@font/inter_semi_bold" | ||
| android:fontFamily="@font/src_inter_bold" |
There was a problem hiding this comment.
The font resource path @font/src_inter_bold appears to include 'src' in the path, which is unusual and might be incorrect. Android font resources are typically referenced without 'src' in the path. Consider verifying if the correct path should be @font/inter_bold instead.
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- 3a2f1eb: Backup UI
Files Processed (0)
Actionable Comments (0)
Skipped Comments (0)
lealobanov
changed the title
jaymengxy
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #1203
Summary of Changes
Need Regression Testing
Risk Assessment
Additional Notes
Screenshots (if applicable)