Skip to content

Conversation

@zhouxl
Copy link
Collaborator

@zhouxl zhouxl commented Jan 4, 2026

Related Issue

Summary of Changes

Need Regression Testing

  • Yes
  • No

Risk Assessment

  • Low
  • Medium
  • High

Additional Notes

Screenshots (if applicable)

@zhouxl zhouxl requested a review from a team as a code owner January 4, 2026 04:52
@github-actions
Copy link

github-actions bot commented Jan 4, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions
Copy link

github-actions bot commented Jan 4, 2026

PR Summary

Updated the React Native bridge to support EVM addresses and added new navigation-related enums. The changes include making the avatar field optional in WalletProfile, adding an optional evmAddress field to SeedPhraseGenerationResponse and SPResponse models, and introducing three new enums (InitialRoute, NativeScreenName, ScreenName) for navigation purposes. The saveMnemonic function signature was updated to accept an optional evmAddress parameter. Additionally, the react-native-render-html dependency was added to the project.

Changes

File Summary
FRW/Foundation/Bridge/BridgeModels.swift Made avatar optional in WalletProfile. Added optional evmAddress field to SeedPhraseGenerationResponse and SPResponse structs. Introduced three new enums: InitialRoute, NativeScreenName, and ScreenName for navigation routing with various screen identifiers.
FRW/Foundation/Bridge/RCTNativeFRWBridge.mm Updated saveMnemonic method signature to include a new evmAddress parameter of type NSString *. The parameter is passed through to the TurboModuleSwift.saveMnemonicWithMnemonic completion handler.
FRW/Foundation/Bridge/TurboModule+Onboard.swift Added EVM address generation using key.ethAddress() when creating seed phrase. Updated SeedPhraseGenerationResponse to include the generated evmAddress. Modified saveMnemonic function signature to accept optional evmAddress parameter.
Podfile.lock Added react-native-render-html (version 6.3.4) as a new dependency. Updated checksums for multiple React Native pods reflecting version updates or rebuilds.
main.jsbundle Updated compiled JavaScript bundle reflecting the React Native changes.

autogenerated by presubmit.ai

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Review Summary

Commits Considered (1)
Files Processed (5)
  • FRW/Foundation/Bridge/BridgeModels.swift (3 hunks)
  • FRW/Foundation/Bridge/RCTNativeFRWBridge.mm (1 hunk)
  • FRW/Foundation/Bridge/TurboModule+Onboard.swift (2 hunks)
  • Podfile.lock (5 hunks)
  • main.jsbundle (0 hunks)
Actionable Comments (0)
Skipped Comments (2)
  • FRW/Foundation/Bridge/TurboModule+Onboard.swift [105-105]

    possible issue: "Unused function parameter."

  • FRW/Foundation/Bridge/TurboModule+Onboard.swift [40-40]

    possible issue: "Silent error handling may hide failures."

@zhouxl zhouxl merged commit 9669aa7 into dev Jan 4, 2026
4 checks passed
@zhouxl zhouxl deleted the 310/972-onboard-bridge-fix branch January 4, 2026 04:56
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Review Summary

Commits Considered (1)
  • fd4824a: Merge branch 'dev' into 310/972-onboard-bridge-fix
Files Processed (0)
Actionable Comments (0)
Skipped Comments (0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants