-
Notifications
You must be signed in to change notification settings - Fork 6
feat: update RN bridge #2231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update RN bridge #2231
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
PR SummaryUpdated the React Native bridge to support EVM addresses and added new navigation-related enums. The changes include making the Changes
autogenerated by presubmit.ai |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM!
Review Summary
Commits Considered (1)
- 1821e98: feat: update RN bridge
Files Processed (5)
- FRW/Foundation/Bridge/BridgeModels.swift (3 hunks)
- FRW/Foundation/Bridge/RCTNativeFRWBridge.mm (1 hunk)
- FRW/Foundation/Bridge/TurboModule+Onboard.swift (2 hunks)
- Podfile.lock (5 hunks)
- main.jsbundle (0 hunks)
Actionable Comments (0)
Skipped Comments (2)
-
FRW/Foundation/Bridge/TurboModule+Onboard.swift [105-105]
possible issue: "Unused function parameter."
-
FRW/Foundation/Bridge/TurboModule+Onboard.swift [40-40]
possible issue: "Silent error handling may hide failures."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM!
Review Summary
Commits Considered (1)
- fd4824a: Merge branch 'dev' into 310/972-onboard-bridge-fix
Related Issue
Summary of Changes
Need Regression Testing
Risk Assessment
Additional Notes
Screenshots (if applicable)