-
Notifications
You must be signed in to change notification settings - Fork 6
feat: add key rotation example #2239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
PR SummaryAdded a native-to-React Native bridge infrastructure for key rotation functionality. This includes new event emitter classes for bidirectional communication, models for key rotation check parameters and results, and integration with Changes
autogenerated by presubmit.ai |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 Pull request needs attention.
Review Summary
Commits Considered (1)
- 1fd9c2e: feat: add key rotation example
Files Processed (8)
- FRW.xcodeproj/project.pbxproj (9 hunks)
- FRW/Foundation/Bridge/NativeEventModels.swift (1 hunk)
- FRW/Foundation/Bridge/NativeRequestEventEmitter.h (1 hunk)
- FRW/Foundation/Bridge/NativeRequestEventEmitter.m (1 hunk)
- FRW/Foundation/Bridge/RCTNativeFRWBridge.mm (1 hunk)
- FRW/Foundation/Bridge/TurboModuleSwift.swift (1 hunk)
- FRW/Foundation/Define/NotificationDefine.swift (1 hunk)
- FRW/Services/Manager/Wallet/WalletManager.swift (4 hunks)
Actionable Comments (1)
-
FRW/Foundation/Bridge/TurboModuleSwift.swift [164-167]
possible issue: "Function body is empty and discards all parameters."
Skipped Comments (3)
-
FRW/Foundation/Bridge/TurboModuleSwift.swift [156-161]
maintainability: "Unused parameters are explicitly discarded without explanation."
-
FRW/Services/Manager/Wallet/WalletManager.swift [547-550]
possible bug: "Missing validation for required notification fields."
-
FRW/Foundation/Bridge/NativeRequestEventEmitter.m [40-42]
possible issue: "Nil userInfo handling may silently drop valid notifications."
| static func removeOldKey(address: String, publicKey: String) async throws { | ||
| _ = address | ||
| _ = publicKey | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removeOldKey function accepts address and publicKey parameters but does nothing with them. This appears to be a stub implementation that should either be completed or documented as a placeholder.
Related Issue
Summary of Changes
Need Regression Testing
Risk Assessment
Additional Notes
Screenshots (if applicable)