fix(ERC4626): use correct token address for max allowed amount conversion #84
+95
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion Fix bug in ERC4626SourceConnector.quoteFor() where uintMaxAllowed was being calculated using the vault's ERC4626 address instead of the underlying asset's address. This caused incorrect decimal conversion when the vault and underlying asset have different decimals. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
nvdtf
approved these changes
Jan 6, 2026
Add regression test to verify quoteIn correctly uses asset decimals instead of vault decimals when calculating max allowed amount. - Add quote_in.cdc script to test quoteIn function directly - Add testQuoteInUsesCorrectDecimalsForMaxAllowed test case 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
liobrasil
force-pushed
the
lionel/fix-erc4626-max-allowed-decimals
branch
from
dac0d21 to
bc1353c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ERC4626SwapConnectors.cdcwhereconvertCadenceAmountToERC20Amountwas using the vault address instead of the asset address when calculatinguintMaxAllowedTest plan
testQuoteInWithLargeAmountReturnsMaxWhenOverflowRegression Test Explanation
The test donates assets directly to the vault (without minting shares) to create a 2:1 asset/share ratio. Then it requests a quote for
UFix64.maxshares:UFix64.maxsafely🤖 Generated with Claude Code