Skip to content

Conversation

@T4Bu
Copy link
Contributor

@T4Bu T4Bu commented Oct 6, 2025

Adds flow config add alias command to add contract aliases to configuration. Supports both interactive and flag-based modes.

@jribbink
Copy link
Contributor

jribbink commented Oct 6, 2025

Hey @T4Bu - thanks for contributing 👋 !

Could you add a test for this? E.g. that the flow.json is modified correctly after the function has rn.

@T4Bu
Copy link
Contributor Author

T4Bu commented Oct 7, 2025

Hello @jribbink no problem, and of course.

@T4Bu
Copy link
Contributor Author

T4Bu commented Oct 7, 2025

I'm assuming it's intentional that addresses in memory have the 0x prefix, while in json they don't? Just mentioning because tests that only check in memory values will pass but will fail when reading explicit json.

@jribbink jribbink force-pushed the feature/add-alias-config branch from 29ef9a2 to ae0983e Compare December 23, 2025 04:54
@jribbink jribbink force-pushed the feature/add-alias-config branch from ae0983e to e5a2e4c Compare December 23, 2025 04:58
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 49.35065% with 39 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/util/util.go 0.00% 15 Missing ⚠️
internal/prompt/prompt.go 0.00% 13 Missing ⚠️
internal/config/add-alias.go 77.08% 7 Missing and 4 partials ⚠️

📢 Thoughts on this report? Let us know!

@jribbink jribbink merged commit 0e7b990 into onflow:master Dec 23, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants