feat(lambda): read cloud.account.id from symlink in Lambda detector#2619
Open
RaphaelManke wants to merge 6 commits intoopen-telemetry:mainfrom
Open
feat(lambda): read cloud.account.id from symlink in Lambda detector#2619RaphaelManke wants to merge 6 commits intoopen-telemetry:mainfrom
RaphaelManke wants to merge 6 commits intoopen-telemetry:mainfrom
Conversation
…ector Read /tmp/.otel-account-id via Files.readSymbolicLink in LambdaResource and set cloud.account.id resource attribute. Silently skips if the symlink does not exist or readlink is unsupported. Preserves leading zeros by treating the value as a string.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for reading the AWS account ID from a symlink created by the OpenTelemetry Lambda Extension. The Lambda resource detector now reads cloud.account.id from /tmp/.otel-aws-account-id, enabling automatic population of this attribute without requiring environment variables.
Changes:
- Added symlink reading logic to LambdaResource with graceful error handling
- Introduced injectable Path parameter for testability while maintaining backward compatibility
- Added comprehensive unit tests covering happy path, missing symlink, and leading zero preservation
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| aws-resources/src/main/java/io/opentelemetry/contrib/aws/resource/LambdaResource.java | Added symlink reading logic with proper error handling, maintained backward compatibility with existing buildResource() method signature |
| aws-resources/src/test/java/io/opentelemetry/contrib/aws/resource/LambdaResourceTest.java | Added three test cases covering symlink reading success, missing symlink graceful handling, and leading zero preservation |
| CHANGELOG.md | Documented the new feature under the Unreleased section |
aws-resources/src/main/java/io/opentelemetry/contrib/aws/resource/LambdaResource.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cloud.account.idfrom the symlink at/tmp/.otel-aws-account-idcreated by the OTel Lambda ExtensionFiles.readSymbolicLink()to read the symlink targetcatch IOException | UnsupportedOperationException)Depends on
Changes
LambdaResource.java— Added readlink logic withACCOUNT_ID_SYMLINK_PATHconstant, injectablePathfor testingLambdaResourceTest.java— Happy path, missing symlink, leading zeros testsTest plan
cloud.account.idset correctly