Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8086 +/- ##
=========================================
Coverage 90.31% 90.32%
+ Complexity 7606 7519 -87
=========================================
Files 839 839
Lines 22888 22888
Branches 2283 2283
=========================================
+ Hits 20672 20674 +2
+ Misses 1506 1505 -1
+ Partials 710 709 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…y-java into okhttp-sender-major-versions
Member
Author
|
New artifact details in maven local: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #8001. Related to #8046.
Currently,
opentelemetry-exporter-sender-okhttpsupports okhttp 4.x and 5.x. We verify this by running our thorough test suite with both versions. This fact is hard to discover. We could advertise it better in our docs. But this pattern probably isn't sustainable and should expect breaking changes in future major version bumps.This PR breaks out a separate
opentelemetry-exporter-sender-okhttp4sender for compatibility with okhttp 4.x.Some points to discuss:
opentelemetry-exporter-sender-okhttpis for okhttp 5.x We could doopentelemetry-exporter-sender-okhttp5, but that's artifact churn which isn't strictly necessary. Of course if v6 comes out, we'd have to publishopentelemetry-exporter-sender-okhttp6. And so at that pointopentelemetry-exporter-sender-okhttpwould look like the outlier. So maybeopentelemetry-exporter-sender-okhttp5is worth considering.We should think about code maintenance. Currently, I just did a straight copy / paste of theWent with an approach where gradle tooling creates generated sources from a single source of truth.opentelemetry-exporter-sender-okhttpcode. This makes it easy for the code to diverge. We could also build gradle tooling to automatically make a copy in a generated source set excluded from gradle. Or similarly, we could build gradle tooling which throws an error if the two copies are out of sync. If breaking changes occur in the next major version, the sender code won't be able to be an exact copy, but we can cross that bridge later.Version management and rennovate needs some thought. For simplicity, I currently just pulled okhttp fromWent with an approach where dependencyManagement uses the okhttp v5 version, and we have two explicit references to okhttp4.dependencyMangement. This leaves version constants scattered around the codebase. Maybe it would be enough to keep thedependencyManagementpinned to the latest, and force resolve to okhttp 4.x only in the select few places that need it.