-
Notifications
You must be signed in to change notification settings - Fork 849
OpenAI v2 onboard onto semantic conventions 1.37.0: chat history and other breaking changes #3715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
OpenAI v2 onboard onto semantic conventions 1.37.0: chat history and other breaking changes #3715
Conversation
|
As a common package we have https://github.com/open-telemetry/opentelemetry-python-contrib/tree/main/util/opentelemetry-util-genai |
|
thanks a lot, @xrmx! |
zhirafovod
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor suggestions, but overall it looks good for this iteration. Thanks for doing it, we can add some notes to follow up on these items in the following pr.
instrumentation-genai/opentelemetry-instrumentation-openai-v2/examples/manual/.env
Outdated
Show resolved
Hide resolved
...opentelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/patch.py
Show resolved
Hide resolved
...ntelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/__init__.py
Outdated
Show resolved
Hide resolved
@xrmx , I would propose we merge this one before the common library is ready. It will provide testing needed to switch to the new library. Also, please review the PRs which are pre-requirement to switching to the util library. |
4d9ba77 to
4887a19
Compare
|
|
||
|
|
||
| def assert_log_parent(log, span): | ||
| """Assert that the log record has the correct parent span context""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops
| "opentelemetry-instrumentation ~= 0.58b0", | ||
| "opentelemetry-semantic-conventions ~= 0.58b0" | ||
| "opentelemetry-semantic-conventions ~= 0.58b0", | ||
| "opentelemetry-util-genai >= 0.2b0, <0.3b0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: 0.3b0.dev is required
a1bbbf9 to
3f0e18a
Compare
Implements new semconv 1.37.0 behind
OTEL_SEMCONV_STABILITY_OPT_IN = gen_ai_latest_experimentalopt-in.TODOs: