Fix docker-tests assumption by Postgres-Sqlalchemy case about scope of metrics#4258
Open
tammy-baylis-swi wants to merge 2 commits intoopen-telemetry:mainfrom
Open
Conversation
tammy-baylis-swi
moved this from Ready for review
to Easy to review / merge / close
in @xrmx's Python PR digest
emdneto
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Merge of span start/end metrics in core (open-telemetry/opentelemetry-python#4880) has revealed one of the contrib docker-tests makes assumptions about shape of exported metrics. The PostgreSQL-SqlAlchemy test case was assuming the only metrics in scope are from its instrumentation. Now there are different scopes: span start, span end, and framework-specific instrumentors.
Example failed run: https://github.com/open-telemetry/opentelemetry-python-contrib/actions/runs/22367683059/job/64737919774
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.