-
Notifications
You must be signed in to change notification settings - Fork 227
ci: Update Test Suite #1833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
ci: Update Test Suite #1833
Conversation
- Adds appraisals for the latest gem versions - Removes appraisals for stale or unsupported gem versions
hannahramadan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
For a few gems (bunny, koala, lmdb, mongo, mysql2, resque, rest-client, ruby-kafka), we started testing the latest release - yay love this.
In those, we also stopped testing specific versions. The PR description notes not testing stale or unsupported gem versions. I'm not sure if any of those gem's^ versions fall into that list, but for any of those, would it make sense to keep a version-tested appraisal loop & have a latest section. Like concurrent_ruby? That does run the risk of slowly testing outdated gems. I dont have a strong pref on this.
Co-authored-by: Hannah Ramadan <76922290+hannahramadan@users.noreply.github.com>
Caveat - Tests for racecar 2.11+ do not currently pass cc: @chrisholmes