Skip to content

Conversation

@zjb0807
Copy link
Contributor

@zjb0807 zjb0807 commented Aug 17, 2025

Closes: #1027

@zjb0807 zjb0807 requested a review from xlc August 17, 2025 14:14
@codecov
Copy link

codecov bot commented Aug 17, 2025

Codecov Report

❌ Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.98%. Comparing base (feb803e) to head (f41fef3).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
xcm-mock-message-queue/src/lib.rs 20.00% 4 Missing ⚠️
benchmarking/src/lib.rs 0.00% 2 Missing ⚠️
xtokens/src/lib.rs 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1030      +/-   ##
==========================================
- Coverage   66.19%   65.98%   -0.21%     
==========================================
  Files          48       48              
  Lines        3686     3687       +1     
==========================================
- Hits         2440     2433       -7     
- Misses       1246     1254       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xlc
Copy link
Member

xlc commented Aug 17, 2025

looks like wasm build wasn't working

@clangenb
Copy link
Contributor

I think you need to set the following flag to fix the wasm build:

export RUSTFLAGS="${RUSTFLAGS:-} --cfg substrate_runtime"

This has been introduced lately due to the pallet-revive build mess.

@zjb0807 zjb0807 requested a review from xlc September 17, 2025 13:33
@xlc xlc merged commit ff056c1 into master Sep 17, 2025
6 of 8 checks passed
@xlc xlc deleted the polkadot-stable2506 branch September 17, 2025 22:01
@zjb0807 zjb0807 restored the polkadot-stable2506 branch September 17, 2025 22:59
github-merge-queue bot pushed a commit to paritytech/polkadot-sdk that referenced this pull request Dec 3, 2025
…strate_runtime` Rustflag (#10514)

Adds a tiny paragraph explaining what one needs to do when compiling
individual crates to WASM.

During the past few months I have seen several issues with build errors
due to missing this flag,
open-web3-stack/open-runtime-module-library#1030 (comment),
#10382,
#9339.

I consider this a low-level detail, hence I put it into the Polkadot SDK
Documentation, however, I thought that this caveat should also be in the
main README. I also added a minimal section regarding PolkaVM, although
I am not sure if this is needed, maybe it is better to just create an
issue to add a PolkaVM build section to the SDK Docs once the PolkaVM
build process stable (maybe it already is).

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support polkadot-stable2506

4 participants