-
Notifications
You must be signed in to change notification settings - Fork 295
Update polkadot-stable2506 #1030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1030 +/- ##
==========================================
- Coverage 66.19% 65.98% -0.21%
==========================================
Files 48 48
Lines 3686 3687 +1
==========================================
- Hits 2440 2433 -7
- Misses 1246 1254 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
looks like wasm build wasn't working |
753164c to
5cab9e4
Compare
|
I think you need to set the following flag to fix the wasm build:
This has been introduced lately due to the pallet-revive build mess. |
…strate_runtime` Rustflag (#10514) Adds a tiny paragraph explaining what one needs to do when compiling individual crates to WASM. During the past few months I have seen several issues with build errors due to missing this flag, open-web3-stack/open-runtime-module-library#1030 (comment), #10382, #9339. I consider this a low-level detail, hence I put it into the Polkadot SDK Documentation, however, I thought that this caveat should also be in the main README. I also added a minimal section regarding PolkaVM, although I am not sure if this is needed, maybe it is better to just create an issue to add a PolkaVM build section to the SDK Docs once the PolkaVM build process stable (maybe it already is). --------- Co-authored-by: Bastian Köcher <git@kchr.de>
Closes: #1027