Feature/examples v0.6 #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # examples/4_filter_and_read_last_value_of_signal.c # examples/6_read_with_formatted_timestamps.c # examples/util_headers/daq_utils.h
misc: Added skeleton structure for application final iteration
It now displays the tree structure of the connected simulator
# Conflicts: # examples/4_filter_and_read_last_value_of_signal.c # examples/6_read_with_formatted_timestamps.c # examples/util_headers/daq_utils.h
It now displays the tree structure of the connected simulator # Conflicts: # examples/2_0_tree_traversal.c
# Conflicts: # examples/CMakeLists.txt
JakaMohorko
requested changes
Jan 22, 2026
tomaz-cvetko
left a comment
tomaz-cvetko
left a comment
There was a problem hiding this comment.
Starting to look really clean, but I think we can make it a bit more polished.
tomaz-cvetko
approved these changes
Jan 27, 2026
tomaz-cvetko
left a comment
tomaz-cvetko
left a comment
There was a problem hiding this comment.
The review comments have been addressed, looks good to me.
JakaMohorko
approved these changes
Jan 29, 2026
Contributor
JakaMohorko
left a comment
JakaMohorko
left a comment
There was a problem hiding this comment.
Few minor comments that should be addressed before merge.
tomaz-cvetko
reviewed
Feb 2, 2026
| switch (compType) | ||
| { | ||
| case DaqDevice: | ||
| printDaqDevice(baseObject, indent + 1); |
There was a problem hiding this comment.
This function doesn't print "parent line plus indented children". So it should just pass on the indent that is given. (no +1).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tree traversal example completed.