fix(core/network): added loan status and align it to network model

[piyushs-05]

Fixes - Jira-#661

Please Add Screenshots If there are any UI changes.

Before	After

Please make sure these boxes are checked before submitting your pull request - thanks!

• Run the static analysis check ./gradlew check or ci-prepush.sh to make sure you didn't break anything

• If you have multiple commits please combine them into one commit by squashing them.

Summary by CodeRabbit

• New Features

  • Loan account status is now shown in loan listing cards, improving at-a-glance visibility.

• Chores

  • Status handling standardized across the network and UI layers to ensure consistent status text is displayed.

[coderabbitai]

Warning

Rate limit exceeded

@piyushs-05 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 11 minutes and 18 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📝 Walkthrough

Walkthrough

Renamed description → value in GetClientsLoanAccountsStatus, updated mapper usages to the new field, added a status: String parameter to MifosActionsLoanListingComponent and its preview, and propagated the new argument into ClientLoanAccountsScreen calls.

Changes

Cohort / File(s)	Summary
Model Property Rename core/network/src/commonMain/kotlin/com/mifos/core/network/model/GetClientsLoanAccountsStatus.kt	Renamed data class property description: String? → value: String?, changing the public field name.
Mapper Updates core/network/src/commonMain/kotlin/com/mifos/core/network/mappers/clients/GetClientsClientIdAccountMapper.kt	Replaced usages of status.description with status.value in mapping functions.
UI Component & Preview core/ui/src/commonMain/kotlin/com/mifos/core/ui/components/MifosActionsListingCardComponent.kt, core/ui/src/commonMain/kotlin/com/mifos/core/ui/components/MifosAllUiComponentsPreview.kt	Added status: String parameter to MifosActionsLoanListingComponent and rendered a status row; updated preview to pass "Active".
Screen Integration feature/client/src/commonMain/kotlin/com/mifos/feature/client/clientLoanAccounts/ClientLoanAccountsScreen.kt	Updated component invocation to pass loan.status?.value (with fallback) as the new status argument.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• fix(client) : Fixed the Loan Accounts Screen not displaying loan details. #2601: Performs the same rename from description → value for loan account status/type and updates mappers/call sites accordingly.

Suggested reviewers

• TheKalpeshPawar
• itsPronay
• biplab1

Poem

🐰 A little field hopped from description to value,
Mappers adjusted steps, the UI learned the new cue,
Screens pass the status with a cheerful cheer,
Carrots applaud the change — compact and clear! 🥕

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: adding and aligning loan status to the network model, which is reflected in the field rename (description → value) and UI component updates.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into development

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

core/network/src/commonMain/kotlin/com/mifos/core/network/model/GetClientsLoanAccountsStatus.kt (1)

24-24: ⚠️ Potential issue | 🟡 Minor

Stale KDoc: @param description should be @param value.

The field was renamed from description to value, but the KDoc still references the old name.

📝 Proposed fix

-  * `@param` description
+  * `@param` value

🧹 Nitpick comments (1)

core/ui/src/commonMain/kotlin/com/mifos/core/ui/components/MifosActionsListingCardComponent.kt (1)

437-441: Consider color-coding the status value for visual consistency.

Other listing components in this file (e.g., MifosActionsIdentifierListingComponent at Line 197) apply color to the status value. Applying a valueColor based on the loan status (e.g., green for active, yellow for pending) would improve scannability and align with the existing pattern.

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

core/network/src/commonMain/kotlin/com/mifos/core/network/model/GetClientsLoanAccountsStatus.kt (1)

14-28: ⚠️ Potential issue | 🟡 Minor

Stale KDoc: @param description should be @param value.

Line 23 still references the old field name description.

Proposed fix

- * `@param` description
+ * `@param` value

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[amanna13]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

core/network/src/commonMain/kotlin/com/mifos/core/network/model/GetClientsLoanAccountsStatus.kt (1)> 14-28: ⚠️ Potential issue | 🟡 Minor

Stale KDoc: @param description should be @param value.
Line 23 still references the old field name description.

Proposed fix

- * `@param` description
+ * `@param` value

@piyushs-05 Consider fixing this suggested change.

[piyushs-05]

@amanna13 ya i fixed in my last commit .