Random-access for variable-based encoding (i.e. use SetStepSelection for ADIOS2 steps)#1706
Merged
ax3l merged 33 commits intoopenPMD:devfrom Feb 20, 2025
Merged
Conversation
4f7284b to
585b084
Compare
238fcd1 to
688ffa9
Compare
e3559c5 to
ecf7039
Compare
franzpoeschel
commented
Feb 13, 2025
franzpoeschel
commented
Feb 13, 2025
franzpoeschel
commented
Feb 13, 2025
franzpoeschel
commented
Feb 13, 2025
This was referenced Feb 13, 2025
e41f041 to
9475398
Compare
9475398 to
7736fbd
Compare
6 tasks
Member
|
#1711 merged, ready for rebase :) |
7736fbd to
4bc01e1
Compare
Contributor
Author
done ;) |
Contributor
Author
|
Note to self: Benchmark this on a Series with many Iterations, compare with group/file encoding and with variable encoding in linear access |
ax3l
reviewed
Feb 18, 2025
|
|
||
| struct StepSelection | ||
| { | ||
| std::optional<size_t> step; |
Member
There was a problem hiding this comment.
please include <optional> for stability in this file
Contributor
Author
There was a problem hiding this comment.
Done, I've also removed an unused <map> import
This covers the use case that the snapshot attribute has more than just one entry.
Previously implementation did not work: ornladios/ADIOS2#4466
4bc01e1 to
b9158a6
Compare
ax3l
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: