Bump toml11 to 4.4.0, nlohmann_json to 3.12.0#1842
Open
franzpoeschel wants to merge 5 commits intoopenPMD:devfrom
Open
Bump toml11 to 4.4.0, nlohmann_json to 3.12.0#1842franzpoeschel wants to merge 5 commits intoopenPMD:devfrom
franzpoeschel wants to merge 5 commits intoopenPMD:devfrom
Conversation
cd56ff7 to
088c8c9
Compare
Contributor
Author
|
Pybind11 3.0.1 seems to explode MSVC: It looks like these troubles are caused by I think that the following workaround could fix it, by never exposing the "get_attribute",
[](Attributable &attr, std::string const &key) {
auto v = attr.getAttribute(key);
- return v.getVariant<attribute_types>();
+ return std::visit(
+ [](auto const &val) { return py::cast(val); },
+ v.getVariant<attribute_types>());
// TODO instead of returning lists, return all arrays (ndim > 0)
// as numpy arrays?
}) |
Contributor
Author
|
Ok, the above workaround did help, however pybind11 still crashes MSVC: Upgrading toml11 and nlohmann_json is more pressing due to the CMake issues, I will bother with the pybind stuff later. |
Contributor
Author
Ref. pybind/pybind11#5968 |
This reverts commit bc1817d.
Pybind's variant handling explodes MSVC, so we do it instead.
38bb163 to
2deea43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also #1839
Updating toml11 and nlohmann_json is needed for CMake 4