Skip to content

Enable Users to Select the appropriate sensor while creating a new Device#705

Open
JerryVincent wants to merge 5 commits intodevfrom
feat/SensorSelection
Open

Enable Users to Select the appropriate sensor while creating a new Device#705
JerryVincent wants to merge 5 commits intodevfrom
feat/SensorSelection

Conversation

@JerryVincent
Copy link
Collaborator

@JerryVincent JerryVincent commented Jan 21, 2026

Type of Change

  • Dependency upgrade
  • Bug fix (non-breaking change)
  • Breaking change
    • e.g. a fixed bug or new feature that may break something else
  • New feature
  • Code quality improvements
    • e.g. refactoring, documentation, tests, tooling, ...

Implementation

Improved sensor selection UX by adding visual guidance for users. When clicking a sensor card (for non-senseBoxHomeV2 devices), the individual parameters now highlight with a pulse animation and an info toast appears instructing users to select specific parameters. Added an instruction banner at the top that adapts based on device type. The highlight auto-clears after 2 seconds to avoid visual clutter.

Checklist

  • I gave this pull request a meaningful title
  • My pull request is targeting the dev branch
  • I have added documentation to my code
  • I have deleted code that I have commented out

Additional Information

@scheidtdav scheidtdav moved this from ⏳ Backlog to Ready for Review in openSenseMap Ongoing Jan 22, 2026
@JerryVincent JerryVincent force-pushed the feat/SensorSelection branch 2 times, most recently from 15a79c9 to 1cc8236 Compare February 11, 2026 12:22
@github-actions
Copy link

github-actions bot commented Feb 11, 2026

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 73.52% 1672 / 2274
🔵 Statements 72.06% 1744 / 2420
🔵 Functions 74.27% 335 / 451
🔵 Branches 61.3% 927 / 1512
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
app/models/device.server.ts 67.66% 69.27% 67.74% 67.66% 170-173, 268, 296-305, 333, 338, 346-348, 354-356, 372-374, 378-380, 435-520, 571-575, 603-609, 614-630, 709-711, 722, 729-733, 739-742, 752, 779, 880-900, 919
Generated in workflow #2054 for commit 824fab4 by the Vitest Coverage Report Action

@JerryVincent JerryVincent force-pushed the feat/SensorSelection branch 2 times, most recently from 371d920 to 52270a3 Compare February 18, 2026 14:23
Copy link
Member

@scheidtdav scheidtdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed:

  • please change "parameters" to "phenomena"/ add translations
  • remove sensebox.kaufen urls (leave image srcs empty for now)

Other than that it looks good!

…ven though the user selects only specific phenomens.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

device creation: make sensor selection clear

3 participants

Comments