Skip to content

Feat/mqtt json schema#732

Draft
jona159 wants to merge 46 commits intodevfrom
feat/mqtt-json-schema
Draft

Feat/mqtt json schema#732
jona159 wants to merge 46 commits intodevfrom
feat/mqtt-json-schema

Conversation

@jona159
Copy link
Contributor

@jona159 jona159 commented Feb 3, 2026

Type of Change

  • Dependency upgrade
  • Bug fix (non-breaking change)
  • Breaking change
    • e.g. a fixed bug or new feature that may break something else
  • New feature
  • Code quality improvements
    • e.g. refactoring, documentation, tests, tooling, ...

Implementation

Checklist

  • I gave this pull request a meaningful title
  • My pull request is targeting the dev branch
  • I have added documentation to my code
  • I have deleted code that I have commented out

Additional Information

  • This PR closes #

@socket-security
Copy link

socket-security bot commented Feb 11, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​react-router/​serve@​7.12.0 ⏵ 7.13.0991006896100
Updated@​react-router/​express@​7.12.0 ⏵ 7.13.01001006996100
Added@​react-router/​node@​7.13.01001007196100
Added@​rjsf/​utils@​6.2.59910010095100
Added@​rjsf/​core@​6.2.59810010095100
Added@​rjsf/​validator-ajv8@​6.2.510010010095100

View full report

@github-actions
Copy link

github-actions bot commented Feb 17, 2026

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 73.36% 1675 / 2283
🔵 Statements 71.93% 1748 / 2430
🔵 Functions 74.17% 336 / 453
🔵 Branches 61.27% 929 / 1516
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
app/lib/decoding-service.server.ts 71.12% 57.73% 71.42% 71.42% 12-13, 22, 31-32, 42-60, 113-117, 132-177, 190, 195-197, 226, 231-233, 237, 278, 292-294, 343-345
app/models/integration.server.ts 20% 16.66% 33.33% 11.11% 6-12, 18-27
app/routes/api.boxes.$deviceId.data.ts 89.28% 68.18% 100% 89.28% 13, 33, 52
app/schema/index.ts 100% 100% 100% 100%
app/schema/integration.ts 50% 100% 0% 50% 9
Generated in workflow #2055 for commit 5cd2800 by the Vitest Coverage Report Action

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, lets give postNewMeasurements "authorization" field another type to pass the x-service-key:

interface PostMeasurementsOptions {
	contentType: string
	luftdaten: boolean
	hackair: boolean
	authorization?: string| null  | { 'x-service-key': string } // new type here
}

postNewMeasurements can then check if a known integration sent the request and use the service key instead of a devices apikey for authorization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments