Skip to content

Conversation

@fjord-oai
Copy link

@fjord-oai fjord-oai commented Dec 22, 2025

Motivation

  • Bring codex exec resume to parity with top‑level flags so global options (git check bypass, json, model, sandbox toggles) work after the subcommand, including when outside a git repo.
  • Fix CI’s musl build for the CLI and avoid premature 10‑minute cancellations.

Description

  • CI: build the correct crate (-p codex-cli --bin codex) and extend the workflow timeout to 30 minutes in .github/workflows/ci.yml.
  • Exec CLI: mark --skip-git-repo-check, --json, --model, --full-auto, and --dangerously-bypass-approvals-and-sandbox as global so they’re accepted after resume.
  • Tests: add exec_resume_accepts_global_flags_after_subcommand to verify those flags work when passed after resume.

Testing

  • just fmt
  • cargo test -p codex-exec (pass; ran with elevated perms to allow network/port binds)
  • Manual: exercised codex exec resume with global flags after the subcommand to confirm behavior.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@fjord-oai
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@fjord-oai
Copy link
Author

recheck

github-actions bot added a commit that referenced this pull request Dec 22, 2025
@fjord-oai fjord-oai marked this pull request as ready for review December 22, 2025 20:21
@fjord-oai fjord-oai requested a review from bolinfest December 30, 2025 22:00
@fjord-oai fjord-oai force-pushed the codex/check-image-support-for-codex-exec-resume branch from 98640de to 6de6bfb Compare January 2, 2026 21:44
@fjord-oai fjord-oai changed the title Support images for codex exec resume (add --image to resume) Allow global exec flags after resume and fix CI codex build/timeout Jan 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants