[chore] move app server tests from chat completion to responses #8939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celia-oai
changed the title
celia-oai
force-pushed
the
dev/cc/responses-test
branch
from
c37992e to
f014ee8
Compare
celia-oai
force-pushed
the
dev/cc/responses-test
branch
from
f014ee8 to
e82550a
Compare
celia-oai
changed the title
pakrym-oai
approved these changes
Jan 8, 2026
owenlin0
reviewed
Jan 8, 2026
Collaborator
owenlin0
left a comment
owenlin0
left a comment
There was a problem hiding this comment.
thanks for doing this! 🙌
|
|
||
| Mock::given(method("POST")) | ||
| .and(path("/v1/chat/completions")) | ||
| .and(path_regex(".*/responses$")) |
Collaborator
There was a problem hiding this comment.
curious, why regex instead of just path("/v1/responses")?
|
|
||
| Mock::given(method("POST")) | ||
| .and(path("/v1/chat/completions")) | ||
| .and(path_regex(".*/responses$")) |
| name = "Mock provider for test" | ||
| base_url = "{server_uri}/v1" | ||
| wire_api = "chat" | ||
| wire_api = "responses" |
Collaborator
There was a problem hiding this comment.
wonder if we can just remove all of these lines from all of these test configs now:
model_provider = "mock_provider"
[model_providers.mock_provider]
name = "Mock provider for test"
base_url = "{server_uri}/v1"
wire_api = "responses"
request_max_retries = 0
stream_max_retries = 0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are deprecating chat completions. Move all app server tests from chat completion to responses.