Skip to content

Add options for customizing the way to establish a connection via websockets library #2264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
aligokalppeker wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Add options for customizing the way to establish a connection via websockets library #2264

aligokalppeker wants to merge 11 commits into from
+608 −5

Conversation

@aligokalppeker
Copy link
Contributor

@aligokalppeker aligokalppeker commented Jan 6, 2026 •
edited
Loading

This PR provides web socket connection configurability for the real-time bot communication. Fixes the enhancement request #2234 i have issued

@aligokalppeker
Copy link
Contributor Author

aligokalppeker commented Jan 6, 2026

@seratch, can you please review this ? thx

@seratch seratch changed the title Feature/realtime connection features Add options for customizing the way to establish a connection via websockets library Jan 6, 2026
seratch
seratch requested changes Jan 6, 2026
View reviewed changes
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add unit tests for covering the scenario?

src/agents/realtime/model.py
pass


class TransportConfig(TypedDict):
Copy link
Member

@seratch seratch Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these properties are websockets library specific, so I am thinking of a better naming. I am focusing on other stuff (especially making the HITL successful) so let me hold off deciding details here for now

Copy link
Contributor Author

@aligokalppeker aligokalppeker Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, waiting for it. One note, these are fairly common concepts that also exist in other WebSocket libraries, as keeping alive through pings is a WebSocket standard.

@seratch seratch marked this pull request as draft January 6, 2026 08:59
@seratch seratch added the enhancement New feature or request label Jan 6, 2026
@aligokalppeker
Copy link
Contributor Author

aligokalppeker commented Jan 7, 2026

can you add unit tests for covering the scenario?

@seratch I have added the unit tests covering the changes to the related parameters. Please review.

@aligokalppeker
Copy link
Contributor Author

aligokalppeker commented Jan 8, 2026

@seratch I have added test suites that support the cases and also test the parameter updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seratch seratch seratch requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or request feature:realtime

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aligokalppeker @seratch