Skip to content

Conversation

@SirRGB
Copy link
Contributor

@SirRGB SirRGB commented Oct 19, 2023

No description provided.

@tsterbak tsterbak added documentation Improvements or additions to documentation enhancement New feature or request hacktoberfest labels Oct 19, 2023
@tsterbak
Copy link
Member

Nice changes! :)

Since you already are changing the Xiaomi configs, there is a change that seems necessary to me (maybe @anon1892 has a different opinion).

The final fastboot_reboot_recovery step should be changed to a confirm_button step like done here: https://github.com/openandroidinstaller-dev/openandroidinstaller/pull/326/files#diff-81d204d73cd727595da6dbb4949fb566faa974cd21533cd8bfee642071408cb0

@MagicLike MagicLike self-requested a review October 19, 2023 13:52
@MagicLike MagicLike added hacktoberfest-accepted PR accepted for Hacktoberfest and removed hacktoberfest labels Oct 19, 2023
@SirRGB
Copy link
Contributor Author

SirRGB commented Oct 19, 2023

Im not really at the point of understanding the program. Atm I mostly copy paste/adjust configs and improve the docs...

@SirRGB
Copy link
Contributor Author

SirRGB commented Oct 19, 2023

So confirm_button creates the popup and warnings?
Which configs were you referring to?

* basically all A10+ roms use the A10 firmware
@tsterbak
Copy link
Member

So confirm_button creates the popup and warnings?

confirm_button basically just shows the content text on the view and adds a button to confirm to continue. So there is no script run. This is suitable for steps were you just interact with the device and the installer can do nothing (like pressing buttons on the phone).

Which configs were you referring to?

Basically all Xiaomi ones, I guess

@tsterbak tsterbak added this to the Release Beta-Version 0.5.1 milestone Oct 29, 2023
@tsterbak tsterbak merged commit 0ecefc3 into openandroidinstaller-dev:dev Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request hacktoberfest-accepted PR accepted for Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants