Skip to content

fixup skiplist: fixed issue of uninitialized variables in extreme sit… #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pixclk merged 1 commit into from
Mar 1, 2025
Merged

fixup skiplist: fixed issue of uninitialized variables in extreme sit… #659

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions src/skiplist.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,10 @@ skipnode_find(bfdev_skip_head_t *head, bfdev_find_t find,
return NULL;

list = &head->nodes[level - 1];
end = &head->nodes[level - 1];
end = list;

for (; level--; --list, --end) {
retval = BFDEV_LT;
bfdev_list_for_each_continue(list, end) {
walk = bfdev_list_entry(list, bfdev_skip_node_t, list[level]);
retval = find(walk->key, pdata);
Expand All @@ -48,7 +49,7 @@ skipnode_find(bfdev_skip_head_t *head, bfdev_find_t find,
}
}

if (retval == 0) {
if (!retval) {
if (plev)
*plev = level + 1;
return walk;
Expand All @@ -63,16 +64,12 @@ skipnode_find(bfdev_skip_head_t *head, bfdev_find_t find,
export bfdev_skip_node_t *
bfdev_skiplist_find(bfdev_skip_head_t *head, bfdev_find_t find, void *pdata)
{
bfdev_skip_node_t *node;

node = skipnode_find(head, find, pdata, NULL);

return node;
return skipnode_find(head, find, pdata, NULL);
}

export int
bfdev_skiplist_insert(bfdev_skip_head_t *head, void *key, bfdev_cmp_t cmp,
void *pdata)
bfdev_skiplist_insert(bfdev_skip_head_t *head, void *key,
bfdev_cmp_t cmp, void *pdata)
{
const bfdev_alloc_t *alloc;
bfdev_list_head_t *list, *end;
Expand Down
Loading