Take care of libraries

[schiermi]

• Avoid compile time warnings from CircularBuffer like…

In file included from src/OpenBikeSensorFirmware.h:29,
                 from src/configServer.cpp:30:
.pio/libdeps/esp32dev/CircularBuffer/CircularBuffer.h:3:102: note: #pragma message: WARNING: please change import directive from CircularBiffer.h to CircularBuffer.hpp
 #pragma message("WARNING: please change import directive from CircularBiffer.h to CircularBuffer.hpp")

• https://github.com/fhessel/esp32_https_server seems to be unmaintained since a while and throws deprecation warnings by the used TLS library openssl. https://github.com/jasenk2/esp32_https_server/tree/esp_tls at least addresses this deprecation.

A build containing those changes was tested for three weeks "on the bike". Testing included track uploads & OBS Webinterface access.

[amandel]

The fork does not include the CN fix - when I remember correctly this was mainly needed for Apple devices.

fhessel/esp32_https_server@253013d

[amandel]

Thanks @schiermi for the contribution!

[schiermi]

OK, I missed the CN fix.
New approach based on the currently better maintained fork https://github.com/jackjansen/esp32_idf5_https_server with cherry-picked commits from https://github.com/amandel/esp32_https_server/tree/hotfix/openbikesensor. If tests with Apple devices work well, it should be worth a try to get the commits into https://github.com/jackjansen/esp32_idf5_https_server

I should be able to test certificates, generated based on this branch, with Apple devices in the next days.

[amandel]

Great! Would be good to find the one well maintained fork of the lib!

[schiermi]

Verified successfully & opened PR.

[gluap]

@amandel @schiermi I just noticed that this is still open. I read the communication above as "we're ready to merge". is that right?

[schiermi]

Unfortunately it seems the "maintenance" in https://github.com/jackjansen/esp32_idf5_https_server (on which most of my branch consists of) was also more like a one-time-shot.
In practice the builds based on https://github.com/schiermi/esp32_idf5_https_server#hotfix/openbikesensor are working without issues (on my own OBS).
Should we move this state below https://github.com/openbikesensor/? We could cherry-pick changes from other forks of esp32_idf5_https_server as we need/want them into our own copy? In the end we need something which just works instead of a commercial grade, audited TLS implementation.