feat(Orders): Add createdBy argument and createdByUsers resolver to OrdersCollectionQuery
#11287
Conversation
| nodes: { | ||
| type: new GraphQLList(GraphQLOrder), | ||
| }, | ||
| createdByUsers: { |
There was a problem hiding this comment.
Not sure about the naming, alternative suggestions:
creators?createdBy?
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
| const orderWhereClause = sequelize.queryInterface.queryGenerator | ||
| .getWhereConditions(baseWhere, 'o', models.Order) | ||
| .replace(/"Order"\./g, 'o.'); |
There was a problem hiding this comment.
I can't find this getWhereConditions in the docs nor in current sequelize's source code. Any link to check what it does and how it's implemented?
There was a problem hiding this comment.
It's a private function in Sequelize v6 (the version we're using): https://github.com/sequelize/sequelize/blob/v6/src/dialects/abstract/query-generator.js#L2846
But you're right, can't find it in v7. Will refactor this.
There was a problem hiding this comment.
@Betree I've pushed a refactor to use the Sequelize query builder instead of raw sql here, required some tweaks in how to filter is applied compared to the main collection query. The filters are now manually added to createdByUsers resolver, and it is only target those that are relevant to produce the different dashboard tools for now.
gustavlrsn
force-pushed
the
feat/orders-created-by-argument
branch
from
053bf59 to
2acd200
Compare
gustavlrsn
force-pushed
the
feat/orders-created-by-argument
branch
2 times, most recently
from
0c7c2b3 to
88dd6c1
Compare
gustavlrsn
force-pushed
the
feat/orders-created-by-argument
branch
from
e61f654 to
f97e341
Compare
Betree
left a comment
Betree
left a comment
There was a problem hiding this comment.
The code looks good to me. Can we add some tests to test/server/graphql/v2/collection/OrdersCollectionQuery.test.ts to cover this new behavior?
|
@Betree added some tests for the |
Co-authored-by: Benjamin Piouffle <benjamin@opencollective.com>
Co-authored-by: Benjamin Piouffle <benjamin@opencollective.com>
Co-authored-by: Benjamin Piouffle <benjamin@opencollective.com>
gustavlrsn
force-pushed
the
feat/orders-created-by-argument
branch
from
5669a92 to
60e9c6d
Compare
For opencollective/opencollective#8449
Description
createdByargument to the OrdersCollectionQuery, allowing filtering on who created the ordercreatedByUsersresolver to the OrdersCollectionQuery, to return a list of who created the orders for the current filters