-
Notifications
You must be signed in to change notification settings - Fork 4.2k
docs: create schema for enrollment api #37846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
docs: create schema for enrollment api #37846
Conversation
|
Thanks for the pull request, @wgu-jesse-stewart! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive documentation for the Instructor Dashboard Enrollment API v2, establishing the design foundation for migrating enrollment management functionality from legacy endpoints to RESTful patterns that support MFE development.
Key changes:
- Documents RESTful API design with sync/async execution models based on operation scope
- Specifies pagination, optional fields, authentication, error handling, and email notification patterns
- Establishes OpenAPI specification as implementation reference (to be deleted after deployment)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
lms/djangoapps/instructor/docs/references/instructor-v2-enrollment-api-spec.yaml |
Complete OpenAPI 2.0 specification defining enrollment endpoints, request/response schemas, authentication, and error handling |
lms/djangoapps/instructor/docs/decisions/0003-instructor-enrollment-api-spec.rst |
ADR documenting design decisions including RESTful patterns, sync/async execution model, pagination strategy, and alternatives considered |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lms/djangoapps/instructor/docs/references/instructor-v2-enrollment-api-spec.yaml
Outdated
Show resolved
Hide resolved
lms/djangoapps/instructor/docs/decisions/0003-instructor-enrollment-api-spec.rst
Outdated
Show resolved
Hide resolved
brianjbuck-wgu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read through this and didn't see anything glaring.
Issue: 37814
Description
docs: Add ADR and OpenAPI specification for Instructor Enrollment API This PR adds an architectural decision record (ADR) and OpenAPI specification for the Instructor Dashboard Enrollment API endpoints. These documentation files provide the design rationale and technical contract for the v2 enrollment API implementation, following Open edX REST API Conventions.
Changes
Supporting information
Related to the Instructor Dashboard modernization effort. These documents establish the foundation for migrating enrollment management functionality from legacy endpoints (lms/djangoapps/instructor/enrollment.py) to RESTful patterns supporting MFE development. The design follows Open edX REST API Conventions including: