Skip to content

fix: Nits on styles of library icon [FC-0114]#37980

Open
ChrisChV wants to merge 4 commits intoopenedx:masterfrom
open-craft:chris/fix-library-icon-styles
Open

fix: Nits on styles of library icon [FC-0114]#37980
ChrisChV wants to merge 4 commits intoopenedx:masterfrom
open-craft:chris/fix-library-icon-styles

Conversation

@ChrisChV
Copy link
Contributor

@ChrisChV ChrisChV commented Feb 5, 2026

Description

  • Fixes the issues described in Library Indicator Tooltips frontend-app-authoring#2762 (comment):
    • Changed the background color for the library icon in the unit page.
    • Update punctuation for the library icon tooltip in the unit page.
    • Allows breaking the tooltip into multiple lines.
  • Which edX user roles will this change impact? "Course Author".
image

Supporting information

Testing instructions

  • Go to the course outline of a course.
  • Create a new unit
  • Add some component from a library.
  • Verify the new background color of the tooltip of the library icon.
  • Verify the text in the different icon states

Deadline

None

Other information

  • The bolding issue needs fixing, but I haven't found a way to do it in the edx-platform legacy code.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 5, 2026
@openedx-webhooks
Copy link

Thanks for the pull request, @ChrisChV!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@ChrisChV
Copy link
Contributor Author

ChrisChV commented Feb 5, 2026

The bolding issue needs fixing, but I haven't found a way to do it in the edx-platform legacy code.

@navinkarkera @rpenido Do you have any idea if this can be done in legacy code?

<button class="library-info-icon two-icons library-sync-button sync-state" data-tooltip="${Text(_("The linked {upstream_name} has updates available")).format(upstream_name=upstream_info.upstream_name)}">

@navinkarkera
Copy link
Contributor

image

@ChrisChV I managed to set bold text inside tooltip by updating tooltip_manager here:https://github.com/open-craft/openedx-platform/blob/74842d2f1bb88fe261f102654f38a50d0910d380/common/static/js/src/tooltip_manager.js#L73

We just need to use .html instead of .text in line 73.

            this.tooltip
                .html(tooltipText)
                .css(this.getCoords(pageX, pageY));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

3 participants