-
Notifications
You must be signed in to change notification settings - Fork 23
chore: make streamed list objects client layer public #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 7e9a960.
WalkthroughThis PR re-enables the StreamedListObjects streaming API feature by making three previously package-private method overloads in OpenFgaClient public, uncommenting the example code and README documentation, and activating the corresponding unit and integration tests. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (5)
💤 Files with no reviewable changes (4)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR makes the streamedListObjects API public by changing the visibility of three method overloads in the OpenFgaClient class from package-private to public, and enables previously disabled tests and examples.
- Changed visibility of three
streamedListObjectsmethod overloads from package-private to public - Enabled unit and integration tests by removing
@Disabledannotations - Uncommented the streamed list objects example code and updated its documentation
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/dev/openfga/sdk/api/client/OpenFgaClient.java | Made three streamedListObjects method overloads public |
| src/test/java/dev/openfga/sdk/api/client/StreamedListObjectsTest.java | Removed @Disabled annotation and import to enable unit tests |
| src/test-integration/java/dev/openfga/sdk/api/client/OpenFgaClientIntegrationTest.java | Removed @Disabled annotation and import to enable integration test |
| examples/streamed-list-objects/src/main/java/dev/openfga/sdk/example/StreamedListObjectsExample.java | Uncommented example code by removing comment markers |
| examples/streamed-list-objects/README.md | Removed temporary note about API unavailability |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #272 +/- ##
============================================
+ Coverage 36.59% 37.06% +0.46%
- Complexity 1182 1200 +18
============================================
Files 194 194
Lines 7504 7504
Branches 865 865
============================================
+ Hits 2746 2781 +35
+ Misses 4633 4593 -40
- Partials 125 130 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Makes streamed list objects client layer available for use
Summary by CodeRabbit
New Features
Documentation
Tests
✏️ Tip: You can customize this high-level summary in your review settings.