Old deprecations [note: macOS Makefile randomly fails in this PR]#7667
Old deprecations [note: macOS Makefile randomly fails in this PR]#7667artificiel wants to merge 7 commits intoopenframeworks:masterfrom
Conversation
| #include "ofConstants.h" | ||
| #include "glm/fwd.hpp" | ||
| #include "ofConstants.h" | ||
| #include <deque> |
There was a problem hiding this comment.
pretty sure we need ofConstants included before glm, due to us defining GLM_FORCE_CTOR_INIT
There was a problem hiding this comment.
ahh updated in a commit. but that kind of include order dependency is inherently brittle..
i see there is also a pattern of doing #define GLM_FORCE_CTOR_INIT like e.g.
but that won't help for instance if a library that uses GLM manages to get included before ofConstants...
how about setting GLM_FORCE_CTOR_INIT with a compile -D?
There was a problem hiding this comment.
Agree we need to do GLM_FORCE_CTOR_INIT in all the project files. But that will be a separate PR and will take a bit of time, so need the above change to be reverted to merge :)
|
curious which part of this is addressing: "macOS Makefile randomly fails" |
|
ah sorry for the ambiguity! it means the tests for this PR here are randomly failing in macOS Makefiles. the last run in a Network test, the previous one in a NodeRegression Test. I cannot reproduce the failures, and the tests are otherwise all passing in other platforms. |
closes #1550 expect for:
(not exactly a deprecation) and
not sure what is the role of that function and if it can simply be removed