ofParameterGroup::add(std::shared_ptr<ofAbstractParameter> param);#8127
Open
artificiel wants to merge 3 commits intoopenframeworks:masterfrom
Open
ofParameterGroup::add(std::shared_ptr<ofAbstractParameter> param);#8127artificiel wants to merge 3 commits intoopenframeworks:masterfrom
artificiel wants to merge 3 commits intoopenframeworks:masterfrom
Conversation
Member
|
think this is fine to merge once the conflicts are resolved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ofParameterGroup::add()takes a reference to add a parameter, but internally manages a container of shared_ptr.As discussed here https://forum.openframeworks.cc/t/ofparametergroup-add-with-a-local-ofparameter/43666 sometimes one already has hold of a shared_ptr pointing to a param, and would want to pass it to a group. or someone want to create a parameter and have the group being the sole container for it.
This implements ofParameterGroup::add(std::shared_ptr param) (which, incidentally, is everything but the first line of the original ofParameterGroup::add(ofAbstractParameter & param)
So it is now possible to do:
and the group holds onto the shared_ptr. of course this is a pretty specific application (where you will have to go through the group to get to the parameter).